Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1499 Map Shows Multiple Markers for a Single BBL #1504

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

1499 Map Shows Multiple Markers for a Single BBL #1504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bee1918
Point to nonversioned block centroid table in carto (#1496)
TylerMatteo Mar 21, 2024
af21ed6
Revert "Point to nonversioned block centroid table in carto (#1496)" …
TylerMatteo Mar 21, 2024
c5dc10f
Updated Centroids to query newly created table that removes duplicate…
dhochbaum-dcp Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/project/geometry/geometry.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const METERS_TO_FEET_FACTOR = 3.28084;
const QUERIES = {
DTM_BLOCK_CENTROIDS: `
SELECT the_geom, the_geom_webmercator, cartodb_id, concat(borocode, LPAD(block::text, 5, '0')) as block
FROM dtm_block_centroids_v20201106
FROM dof_dtm_block_centroids_deduped_by_boroblock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to come up with a solution that doesn't require us making a custom one-off table in Carto. The dof_dtm_block_centroids table is updated by GIS automatically and we don't want to introduce new table that we have to manually update. Moreover, I confirmed with Matt Croswell that block numbers aren't intended to be unique within a given borough.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, if block numbers aren't unique within a given borough, wouldn't that mean that two lots could have the same BBL?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my first question but no. You can have two physical blocks with the same block number but they won't re-use lot numbers. You might have two blocks in one borough that are block "5", with three lots on each, but one would have lots 1, 2, 3 and the other would have lots 4, 5, 6, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly this might be rare enough that we don't have to worry about this bug unless it's actually blocking our ability to get radius search working. If the impact is just that users see two dots on the map for projects that happen to overlap with these duplicate blocks, it's not the worst thing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with seeing two dots is that it undermines the credibility of the radius search. When you draw a circle that contains two dots and only one result shows up, it just looks like the filter is broken anyway.

I tried and failed to figure out how to make the SQL only take 1 of each unique concatenated "block", which would solve the issue, but wasn't able to make it work. That would fix the problem without having to create a new table.

`,

centroidsFor(blocks) {
Expand Down
Loading