configure workflow based on zap search #1258
Conversation
✅ Deploy Preview for applicant-portal canceled.
|
.github/workflows/code_quality.yml
Outdated
| - main | ||
| pull_request: | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
@TangoYankee @horatiorosa Maybe this is something we visit but would it be difficult to move these code quality checks into the workflows for deploying the environments? I much prefer things like code quality and tests being in the same workflow as deployments, as separate "jobs". That way you have the option of blocking the deployment if the code quality checks fail. We use this approach in EDDE's workflows.
There was a problem hiding this comment.
yes and no to the difficulty question. We can just copy and paste the code quality checks into each environment workflow.
Long term, we should make the jobs reusable, otherwise we end up needing to update code across several workflows every time we make an updated. Of course, this goes for code quality and deployment jobs (we're mostly reusing code across the deployment workflows, too)
For now, would you like to go forward with copying and pasting code quality checks into each deployment workflow?
TangoYankee
force-pushed
the
main
branch
2 times, most recently
from
8334d77 to
344510d
Compare
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
TangoYankee
had a problem deploying
to
staging
GitHub Actions
Failure
Support deployments from main Deploy to heroku and netlify from github actions Require code quality checks to pass before deploying Fix linting errors to pass quality checks closes #1244 Co-authored-by: horatio <[email protected]>
nvmrc and node engine are updated to 20 in server closes #1241
Protect server and client self service feature with flag closes #1242 Co-authored-by: tangoyankee <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.21.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md) - [Commits](expressjs/express@4.17.1...4.21.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js) from 4.7.6 to 4.7.8. - [Release notes](https://github.com/handlebars-lang/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.8/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.6...v4.7.8) --- updated-dependencies: - dependency-name: handlebars dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.13.0 to 1.15.9. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.13.0...v1.15.9) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
|
Closing because we put these changes on the "default" branch by making |
Summary
Tasks/Bug Numbers