Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace single quotes w/ correct escape #386

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bboudaoud-nv
Copy link
Collaborator

This branch replaces ' characters with '' in order to avoid issues with single quotes in database contents (i.e. experiment configuration) breaking writes to the database.

Merging this branch closes #383

@bboudaoud-nv bboudaoud-nv added bug Something isn't working enhancement New feature or request labels Jul 6, 2022
@bboudaoud-nv bboudaoud-nv requested a review from jspjutNV July 6, 2022 19:03
@bboudaoud-nv bboudaoud-nv self-assigned this Jul 6, 2022
@bboudaoud-nv
Copy link
Collaborator Author

Note that this fix could be addressed separately using #385. Only one of the two should be merged.

Currently this branch has the benefit of maintaining field types using our current approach. #385 treats all values as TEXT type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with ' character in experiment configuration
1 participant