Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omitting R G B from .obj vertex data #760

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

mikerjacobi
Copy link
Contributor

@mikerjacobi mikerjacobi commented Oct 11, 2023

Wavefront .obj files support v X Y Z R G B, which get interpreted by kaolin/io/obj.py:import_mesh as additional vertices. This change omits the R G B values.

Addresses the same issue as this PR, but in a different way.

Copy link
Collaborator

@Caenorst Caenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the MR!

@Caenorst Caenorst merged commit 70c6d20 into NVIDIAGameWorks:master Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants