Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alpha Support to GetTextures Node #3

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

Night1099
Copy link
Contributor

@Night1099 Night1099 commented Sep 2, 2024

If Alpha is detected in image grab alpha and return as mask

Convert Image to RGBA instead of RGB and split into textures and mask return type for alpha support
@nxkb nxkb requested a review from nvdamien September 5, 2024 00:23
Copy link
Collaborator

@nxkb nxkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will get this tested on our side... the only think I want to make sure is whether this requires a version bump or whether adding an extra output port is fine for existing graphs.

We fixed our CLA bot, would you mind the CLA for us? (you can just make a comment)

nodes/textures.py Outdated Show resolved Hide resolved
@Night1099
Copy link
Contributor Author

Night1099 commented Sep 5, 2024

i have tested this in

an older version:
ComfyUI: 2360 commikt 4ca9b9 (2024-07-12)

and a recent version

ComfyUI: 2641 commit f1c230 (2024-09-01)

With no problems, Shouldnt affect current graphs as its not neccesary to use

How do I do the CLA?

@nxkb
Copy link
Collaborator

nxkb commented Sep 5, 2024

Great. Can you rebase this PR on main and push? I think that will trigger the CLA instructions.

Copy link

github-actions bot commented Sep 5, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Night1099
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@nxkb
Copy link
Collaborator

nxkb commented Sep 6, 2024

I have read the CLA Document and I hereby sign the CLA

@nxkb nxkb merged commit af18f19 into NVIDIAGameWorks:main Sep 7, 2024
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants