-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alpha Support to GetTextures Node #3
Conversation
Convert Image to RGBA instead of RGB and split into textures and mask return type for alpha support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will get this tested on our side... the only think I want to make sure is whether this requires a version bump or whether adding an extra output port is fine for existing graphs.
We fixed our CLA bot, would you mind the CLA for us? (you can just make a comment)
i have tested this in an older version: and a recent version ComfyUI: 2641 commit f1c230 (2024-09-01) With no problems, Shouldnt affect current graphs as its not neccesary to use How do I do the CLA? |
Great. Can you rebase this PR on main and push? I think that will trigger the CLA instructions. |
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
I have read the CLA Document and I hereby sign the CLA |
If Alpha is detected in image grab alpha and return as mask