Simple and small refactoring - Remove redundant else block in the XPBD simulator

[kristijanbartol]

Category

• New feature
• Bugfix
• Breaking change
• Refactoring
• Documentation
• Other (please explain)

Description

A very simple pull request, removing the redundant else block, i.e., if and else blocks are identical.

Changelog

• warp/sim/integrator_xpbd.py -> L2811-2816 (remove the latter three lines).

Before your PR is "Ready for review"

• Do you agree to the terms under which contributions are accepted as described in Section 9 the Warp License?
• Have you read the Contributor Guidelines?
• Have you written any new necessary tests?
• Have you added or updated any necessary documentation?
• Have you added any files modified by compiling Warp and building the documentation to this PR (.e.g. stubs.py, functions.rst)?
• Does your code pass ruff check and ruff format --check?

[shi-eric]

Hey @kristijanbartol, can you please rebase your changes so that there is only a single commit?

[kristijanbartol]

Hi @shi-eric! There should be only a single commit now.

[kristijanbartol]

Hi! I might have messed it up by pulling the latest changes to my branch at this point. I don't want to 'git push -f' anything until we agree upon it to avoid further degradation.

Should I now rebase all the commits into one again, with the commit I recently pulled from the main? Sorry for the inconvenience!

[shi-eric]

Hi! I might have messed it up by pulling the latest changes to my branch at this point. I don't want to 'git push -f' anything until we agree upon it to avoid further degradation.

Should I now rebase all the commits into one again, with the commit I recently pulled from the main? Sorry for the inconvenience!

I think it's worth the risk to rebase into a single commit. When I look at the Files changed tab, it's still just the one change you made. Plus, if something unintended happens, you can always close this pull request and make a new one that has only one commit. Sorry to nitpick, just wanted to make sure we don't add more commits than needed!

[kristijanbartol]

Great, I think it got sorted out. I force-pushed the squashed commit, and then the PR included additional changes from the latest commit from the main branch. When I rebased (not merged) the main again, I had only my changes visible and the latest main.

It makes sense now, thanks for the support!

[shi-eric]

Thanks for the pull request! Your changes are merged now.