Replace more generic ValueError with specific FileNotFoundError for warp.sim.load_mesh #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
Description
Changing the error type of the warp.sim.load_mesh function for files which don't exist makes it easier to differentiate between wrong paths and invalid meshes programmatically.
Example: Iterating over multiple directories to find a mesh with a given name.
Changelog
Changes
raise ValueError(f"File not found: {filename}")
to
raise FileNotFoundError(f"File not found: {filename}")
Before your PR is "Ready for review"
stubs.py
,functions.rst
)?ruff check
andruff format --check
?