-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a case to test ORC writing/reading with lots of nulls #8825
Conversation
…th lots of nulls Signed-off-by: Chong Gao <[email protected]>
build |
This case can pass, but causes this a new issue: #8826. |
@@ -398,6 +398,10 @@ properly without it. These tests assume Delta Lake is not configured and are dis | |||
If Spark has been configured to support Delta Lake then these tests can be enabled by adding the | |||
`--delta_lake` option to the command. | |||
|
|||
### Enabling large data tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to switch this over to scale testing instead? #8811
I was just thinking as a follow on this fits much better there, then it does here. If so I am happy to file a follow on issue to move the test there, rather then try and file an issue to enable these tests in a nightly build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. This adds the test, but I don't see any changes to CI scripts or other things that would actually run this test in practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not running. As discussed with Tim and Gary before, will create another CI job to run this kind of tests using:
-m large_date_test --large_date_test
It's fine to move to scale test. The follow-up issue is: #8849
sqls = ["SELECT * FROM my_large_table", | ||
"SELECT * FROM my_large_table WHERE c2 = 5", | ||
"SELECT COUNT(*) FROM my_large_table WHERE c3 IS NOT NULL", | ||
"SELECT * FROM my_large_table WHERE c4 IS NULL", | ||
"SELECT * FROM my_large_table WHERE c5 IS NULL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you! This covers the cases I was hoping for.
Per @revans2's advice, we can move this under the scale tests as a follow-on.
closes #8731
This is to test large number of nulls.
Signed-off-by: Chong Gao [email protected]