Add ORC writing test cases for dictionary compression [databricks] #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <[email protected]>
|
build |
|
Should be able to pass the premerge. |
revans2
previously approved these changes
Jul 25, 2023
tests/src/test/scala/com/nvidia/spark/rapids/OrcQuerySuite.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/OrcQuerySuite.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/OrcQuerySuite.scala
Outdated
Show resolved
Hide resolved
tests/src/test/scala/com/nvidia/spark/rapids/OrcQuerySuite.scala
Outdated
Show resolved
Hide resolved
|
build |
revans2
changed the title
|
build |
revans2
previously approved these changes
Jul 26, 2023
| // get GPU encoding info | ||
| val gpuEncodings = withGpuSparkSession(getEncodings) | ||
|
|
||
| assertResult(cpuEncodings)(gpuEncodings) |
There was a problem hiding this comment.
A little nervous that these will not always be equal, but the test appears to be passing, so I think we might be good.
There was a problem hiding this comment.
The expected result is:
(DICTIONARY_V2, 2) // for column 1
(DICTIONARY_V2, 3) // for column 2
2 and 3 are the dictionary size.
This assert will be always safe.
|
build |
res-life
requested review from
jlowe,
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
revans2
approved these changes
Jul 27, 2023
jlowe
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8797
Add ORC writing test cases for dictionary compression
Signed-off-by: Chong Gao [email protected]