Add test cases for ORC writing according to options orc.compress and compression [databricks] #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compression Signed-off-by: Chong Gao <[email protected]>
|
build |
|
321cdh and 330cdh compile failed. Will fix later. |
|
build |
1 similar comment
|
build |
res-life
changed the title
|
build |
res-life
requested review from
tgravescs,
GaryShen2008,
NvTimLiu and
zhanga5
as code owners
|
build |
revans2
previously approved these changes
Jul 27, 2023
jlowe
reviewed
Jul 27, 2023
mythrocks
reviewed
Jul 27, 2023
| @@ -92,4 +102,76 @@ class OrcQuerySuite extends SparkQueryCompareTestSuite { | |||
| ) { | |||
| frame => frame | |||
| } | |||
|
|
|||
| private def getOrcFilePostfix(compression: String): String = | |||
There was a problem hiding this comment.
Suggested change
| private def getOrcFilePostfix(compression: String): String = | |
| private def getOrcFileSuffix(compression: String): String = |
mythrocks
reviewed
Jul 27, 2023
| // the reader is not a AutoCloseable for Spark CDH, so use `withResourceIfAllowed` | ||
| // 321cdh uses lower ORC: orc-core-1.5.1.7.1.7.1000-141.jar | ||
| // 330cdh uses lower ORC: orc-core-1.5.1.7.1.8.0-801.jar | ||
| withResourceIfAllowed(OrcFile.createReader(orcFilePath, conf)) { reader => |
There was a problem hiding this comment.
This is a useful utility. It makes the code quite streamlined.
mythrocks
reviewed
Jul 27, 2023
| checkCompressType(None, Some(orcCompress)) | ||
| } | ||
|
|
||
| // make paris, e.g.: [("UNCOMPRESSED", "NONE"), ("NONE", "SNAPPY"), ("SNAPPY", "ZSTD") ... ] |
There was a problem hiding this comment.
Suggested change
| // make paris, e.g.: [("UNCOMPRESSED", "NONE"), ("NONE", "SNAPPY"), ("SNAPPY", "ZSTD") ... ] | |
| // make pairs, e.g.: [("UNCOMPRESSED", "NONE"), ("NONE", "SNAPPY"), ("SNAPPY", "ZSTD") ... ] |
mythrocks
previously approved these changes
Jul 27, 2023
added 2 commits
July 28, 2023 10:02
|
build |
jlowe
approved these changes
Jul 28, 2023
thirtiseven
pushed a commit
to thirtiseven/spark-rapids
that referenced
this pull request
Aug 17, 2023
…compression [databricks] (NVIDIA#8785) Signed-off-by: Chong Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8781
closes #8782
ORC writing first honor "compression" option, then "orc.compress" option.
Signed-off-by: Chong Gao [email protected]