-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JSON scan and from_json
#11702
Draft
ttnghia
wants to merge
7
commits into
NVIDIA:branch-24.12
Choose a base branch
from
ttnghia:add_test_from_json
base: branch-24.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
changed the title
Add integration test for
Improve Nov 6, 2024
from_json
with map<string, string>
schemafrom_json
with map<string, string>
schema
Signed-off-by: Nghia Truong <[email protected]>
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
changed the title
Improve
Improve JSON scan and Nov 7, 2024
from_json
with map<string, string>
schemafrom_json
with map<string, string>
schema
ttnghia
changed the title
Improve JSON scan and
Improve JSON scan and Nov 7, 2024
from_json
with map<string, string>
schemafrom_json
Signed-off-by: Nghia Truong <[email protected]>
ttnghia
force-pushed
the
add_test_from_json
branch
from
November 7, 2024 05:23
0b21c8a
to
15a4113
Compare
revans2
previously approved these changes
Nov 7, 2024
Signed-off-by: Nghia Truong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a few improvements for JSON scan and
from_json
:from_json
: support disablingallowSingleQuotes
option.from_json
withmap<string, string>
schema:allowSingleQuotes
,allowNumericLeadingZeros
,allowNonNumericNumbers
, andallowUnquotedControlChars
, along with the corresponding tests.Depends on:
from_json_to_raw_map
spark-rapids-jni#2562