Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSON scan and from_json #11702

Draft
wants to merge 7 commits into
base: branch-24.12
Choose a base branch
from

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Nov 6, 2024

This implements a few improvements for JSON scan and from_json:

  • For both JSON scan and from_json: support disabling allowSingleQuotes option.
  • For from_json with map<string, string> schema:
    • Add the ability to pass down options for turning on/off allowSingleQuotes, allowNumericLeadingZeros, allowNonNumericNumbers, and allowUnquotedControlChars, along with the corresponding tests.
    • Add more tests.

Depends on:

@ttnghia ttnghia added the test Only impacts tests label Nov 6, 2024
@ttnghia ttnghia requested a review from revans2 November 6, 2024 22:32
@ttnghia ttnghia self-assigned this Nov 6, 2024
@ttnghia ttnghia marked this pull request as draft November 6, 2024 22:48
@ttnghia ttnghia changed the title Add integration test for from_json with map<string, string> schema Improve from_json with map<string, string> schema Nov 6, 2024
@ttnghia ttnghia changed the title Improve from_json with map<string, string> schema Improve JSON scan and from_json with map<string, string> schema Nov 7, 2024
@ttnghia ttnghia changed the title Improve JSON scan and from_json with map<string, string> schema Improve JSON scan and from_json Nov 7, 2024
Signed-off-by: Nghia Truong <[email protected]>
revans2
revans2 previously approved these changes Nov 7, 2024
Signed-off-by: Nghia Truong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Only impacts tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants