Fix FileAlreadyExistsException in LORE dump process #11484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi, @ustcfy We also need to add a check that the root dir of lore dump should be empty.
| @@ -197,6 +197,17 @@ object GpuLore { | |||
| s"when ${RapidsConf.LORE_DUMP_IDS.key} is set.")) | |||
|
|
|||
| val spark = SparkShimImpl.sessionFromPlan(sparkPlan) | |||
|
|
|||
| Option(spark.sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY)).foreach { executionId => | |||
| if (!idGen.containsKey(executionId)) { | |||
There was a problem hiding this comment.
This is a bit tricky to me. How about maintaining a hashmap for this check?
|
Please add test for this change, and update dev/lore.md doc. |
ustcfy
changed the title
sql-plugin/src/main/scala/com/nvidia/spark/rapids/lore/GpuLore.scala
Outdated
Show resolved
Hide resolved
|
build |
liurenjie1024
previously approved these changes
Sep 23, 2024
|
build |
2 similar comments
|
build |
|
build |
|
build |
2 similar comments
|
build |
|
build |
liurenjie1024
previously approved these changes
Sep 24, 2024
Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
…checks. Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Signed-off-by: ustcfy <[email protected]>
Co-authored-by: Renjie Liu <[email protected]>
Signed-off-by: ustcfy <[email protected]>
ustcfy
force-pushed
the
fix/lore-dump-exception
branch
from
8366259
to
13784e9
Compare
|
build |
2 similar comments
|
build |
|
build |
| @@ -90,7 +90,7 @@ object GpuLore { | |||
|
|
|||
| def dumpObject[T: ClassTag](obj: T, path: Path, hadoopConf: Configuration): Unit = { | |||
| withResource(path.getFileSystem(hadoopConf)) { fs => | |||
There was a problem hiding this comment.
Not part of this PR, but typically we want to leave the underlying FileSystem.get calls memoized to make the subsequent ones cheaper. Thus the FileSystem object should not be closed via withResource
| executionId => | ||
| loreOutputRootPathChecked.computeIfAbsent(executionId, _ => { | ||
| val path = new Path(loreOutputRootPath) | ||
| withResource(path.getFileSystem(spark.sparkContext.hadoopConfiguration)) { fs => |
There was a problem hiding this comment.
Don't withResource getFileSystem
Signed-off-by: ustcfy <[email protected]>
Co-authored-by: Gera Shegalov <[email protected]>
|
build |
liurenjie1024
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the
FileAlreadyExistsExceptionthat occurs when usingspark.rapids.sql.lore.idsToDumpto dump particular partitions.Changes Made
IllegalArgumentExceptionis thrown to prevent overwriting existing data.