Support non-UTC timezone for casting from date type to timestamp type [databricks] #11462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chong Gao <[email protected]>
res-life
changed the title
|
build |
non-DST timezonepassed: For DST timezone:Report not supporting prompt: |
firestarman
previously approved these changes
Sep 11, 2024
|
|
||
| @pytest.mark.parametrize('parser_policy', ["LEGACY", "CORRECTED", "EXCEPTION"], ids=idfn) | ||
| def test_date_to_timestamp(parser_policy): | ||
| parser_policy_dic = {"spark.sql.legacy.timeParserPolicy": "{}".format(parser_policy)} |
There was a problem hiding this comment.
NIT
Suggested change
| parser_policy_dic = {"spark.sql.legacy.timeParserPolicy": "{}".format(parser_policy)} | |
| all_confs = { | |
| "spark.sql.legacy.timeParserPolicy": "{}".format(parser_policy), | |
| "spark.rapids.sql.incompatibleDateFormats.enabled": True} |
|
build |
|
premerge failed |
firestarman
reviewed
Sep 18, 2024
| "SELECT cast(a as timestamp) from tab", | ||
| conf = { | ||
| "spark.sql.legacy.timeParserPolicy": "{}".format(parser_policy), | ||
| "spark.rapids.sql.incompatibleDateFormats.enabled": True}) |
There was a problem hiding this comment.
Seems we only need spark.rapids.sql.incompatibleDateFormats.enabled being true for LEGACY policy?
|
build |
| @@ -671,3 +671,14 @@ def test_timestamp_millis_long_overflow(): | |||
| def test_timestamp_micros(data_gen): | |||
| assert_gpu_and_cpu_are_equal_collect( | |||
| lambda spark : unary_op_df(spark, data_gen).selectExpr("timestamp_micros(a)")) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('parser_policy', ["LEGACY", "CORRECTED", "EXCEPTION"], ids=idfn) | |||
There was a problem hiding this comment.
Any reason to use different quote marks?
Suggested change
| @pytest.mark.parametrize('parser_policy', ["LEGACY", "CORRECTED", "EXCEPTION"], ids=idfn) | |
| @pytest.mark.parametrize('parser_policy', ['LEGACY', 'CORRECTED', 'EXCEPTION'], ids=idfn) |
| "tab", | ||
| "SELECT cast(a as timestamp) from tab", | ||
| conf = { | ||
| "spark.sql.legacy.timeParserPolicy": "{}".format(parser_policy), |
There was a problem hiding this comment.
format redundant?
Suggested change
| "spark.sql.legacy.timeParserPolicy": "{}".format(parser_policy), | |
| "spark.sql.legacy.timeParserPolicy": parser_policy, |
|
Spark 400 building failure is related to #11479 |
|
build |
firestarman
previously approved these changes
Sep 20, 2024
|
build |
gerashegalov
previously approved these changes
Sep 20, 2024
res-life
dismissed stale reviews from gerashegalov and firestarman
via
b49390f
|
build |
firestarman
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11461
Only support non-DST(daylight saving time) time zones.
Signed-off-by: Chong Gao [email protected]