Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golang-ci-lint errors #972

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix golang-ci-lint errors #972

merged 2 commits into from
Sep 30, 2024

Conversation

elezar
Copy link
Member

@elezar elezar commented Sep 30, 2024 •
edited
Loading

This PR makes the following changes to address golangci-lint errors:

  • updates the GetCudaDriverVersion return type to (int, int, error) instead of (*uint, *uint, error). This prevents unneeded type conversions and pointer operations.
  • adds an explicit check in the testing-only int -> uint64 type conversion for MIG memory.

@elezar elezar self-assigned this Sep 30, 2024
@elezar elezar changed the title Don't return pointers in GetCudaDriverVersion Fix golang-ci-lint errors Sep 30, 2024
ArangoGutierrez
ArangoGutierrez approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@elezar elezar merged commit 04e2a1c into NVIDIA:main Sep 30, 2024
8 checks passed
@elezar elezar deleted the fix-ci-lint branch September 30, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@tariq1890 tariq1890 tariq1890 approved these changes

Assignees

@elezar elezar

Labels
must-backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elezar @tariq1890 @ArangoGutierrez