Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing cuda.core: pythonic access to CUDA core functionalities #87

Merged
merged 34 commits into from
Oct 10, 2024

Conversation

leofang
Copy link
Member

@leofang leofang commented Sep 3, 2024

xref: #70

This is a highly experimental feature currently for preview purposes only, not for production use.

The current focus is centering around a correct, robust, and future-proof design of pythonic CUDA APIs, aiming to boost Python CUDA developers' productivity, among other things. This PR can be considered as a reference/prototype implementation for correctness checks and as a playground, with performance improvements coming next once the design is converged and approved.

More to come in the near future!

TODOs before merging (into the cuda_py branch just forked from main):

  • Sync up with the (internal) design doc (ex: rename to cuda.core)
  • Expand/update PR description
  • Add README
  • Polish & check in test files (tracked in Add basic functionality tests for cuda.core #78)
  • Polish & check in example files
  • Update DLpack support
  • Rerun tests with CUDA 11 driver & CTK
  • Fix (?) dependencies on the Python bindings
  • Add GPUMemoryView prototype
  • Add documentation (tracked in Documentation stage #79)

A separate issue will be created to track needed changes after merging (but before a beta release).

Copy link

copy-pr-bot bot commented Sep 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang force-pushed the cuda_py branch 2 times, most recently from 82c6981 to 5646808 Compare September 4, 2024 03:59
Copy link

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few drive-by things I noticed.

cuda_py/cuda/py/_compiler.py Outdated Show resolved Hide resolved
cuda_py/cuda/py/_compiler.py Outdated Show resolved Hide resolved
cuda_py/cuda/py/_compiler.py Outdated Show resolved Hide resolved
cuda_py/cuda/py/_event.py Outdated Show resolved Hide resolved
@leofang leofang changed the base branch from cuda_py to main October 8, 2024 18:11
@leofang leofang added this to the cuda.core beta 1 milestone Oct 8, 2024
@leofang
Copy link
Member Author

leofang commented Oct 9, 2024

Update: To unblock parallel developments I will merge this PR soon (~tomorrow) so that subsequent PRs can start targeting the main branch of this repo, after checking in the following changes:

  • GPUMemoryView -> StridedMemoryView (done in commit a41a4b7)
  • Add a sample code for StridedMemoryView

@leofang leofang changed the title WIP: Introducing cuda.core: pythonic access to CUDA core functionalities Introducing cuda.core: pythonic access to CUDA core functionalities Oct 10, 2024
@leofang leofang marked this pull request as ready for review October 10, 2024 04:35
@leofang
Copy link
Member Author

leofang commented Oct 10, 2024

Merging! cc @ksimpson-work

@leofang leofang merged commit 797286b into NVIDIA:main Oct 10, 2024
@leofang leofang deleted the cuda_py branch October 10, 2024 04:36
@leofang leofang linked an issue Oct 10, 2024 that may be closed by this pull request
@leofang leofang self-assigned this Oct 10, 2024
@leofang leofang added the cuda.core Everything related to the cuda.core module label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module feature New feature or request P0 High priority - Must do!
Projects
None yet
2 participants