Add ruff linter #201
Open
Add ruff linter #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
ksimpson-work
requested review from
vzhurba01,
leofang and
rwgk
and removed request for
vzhurba01
|
The actions seem to be broken as of a long time ago. The culprit being a faulty build command which looks for setup.py in cuda-python top level directory. I'm wondering if that will be addressed by QA, or if I/someone should fix it. |
vzhurba01
reviewed
Oct 31, 2024
There was a problem hiding this comment.
I couple of comments:
- Once you're ready, can you try testing the builds and tests across our supported Python versions (3.9 to 3.12) and 3.13? For the bindings just doing 3.9 and 3.13 is probably sufficient(?), just because the build there takes a while. In the past some of my own code formats had issues for certain versions, so some paranoia is creeping in. Surely since this is a linter all of that ought to be ok, but still 🙂.
Would need a follow-up PR into the 11.8.x branch. Just an FYI for when the time comes.Actually no, this shouldn't be necessary since the only change expected on that branch are the bindings which aren't covered by the linter anyways. The only items remaining would be the tests/examples, but that is expected to stay the same.
cuda_bindings/examples/4_CUDA_Libraries/conjugateGradientMultiBlockCG_test.py
Outdated
Show resolved
Hide resolved
rwgk
reviewed
Nov 1, 2024
There was a problem hiding this comment.
Looks good to me, but what do you think about splitting this PR into two parts:
- Add tox testing only.
- Add ruff only with the tox testing in place already.
That would make it easier** to see what changes (if any?) are required to establish tox testing, and what changes are a consequence of introducing ruff.
easier** in the future, in case we have to backtrack for whatever reason.
|
@vzhurba01 The changes have been verified against python 3.9 and 3.13 successfully. |
rwgk
previously approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ruff linter and format to pre-commit-hooks + make the appropriate changes in the code base so that we start with a passing commit.
some per-file ignores have been added, and some globals. I think these can be a work in progress, and I used my best judgement, but I would love to hear feedback.
Depends on #203
The only real bug this exposes is #203 which I am addressing in a separate PR and issue for cleanliness
Closes #195