-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare docs for sub-packages #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
documentation
Improvements or additions to documentation
P0
High priority - Must do!
cuda.bindings
Everything related to the cuda.bindings module
cuda.core
Everything related to the cuda.core module
labels
Oct 12, 2024
This should be ready for review. However, do not merge yet, as I need to do a live demo first before we commit to the changes. |
(Updated the PR description to compare the old/existing urls with the new/expected urls.) |
leofang
changed the title
WIP: Prepare docs for sub-packages
Prepare docs for sub-packages
Oct 15, 2024
vzhurba01
reviewed
Oct 15, 2024
vzhurba01
reviewed
Oct 15, 2024
vzhurba01
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
leofang
commented
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cuda.bindings
Everything related to the cuda.bindings module
cuda.core
Everything related to the cuda.core module
documentation
Improvements or additions to documentation
P0
High priority - Must do!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #94. Close #95.
This PR prepares for the documentation infrastructure for adding sub-packages. This introduces a (hopefully one-time only) breaking change to the existing doc urls. Two major changes are:
cuda-python
into a metapackage #105)Old urls:
New urls: