Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply remaining touch ups for patch release #158

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Apply remaining touch ups for patch release #158

merged 1 commit into from
Oct 11, 2024

Conversation

vzhurba01
Copy link
Collaborator

@vzhurba01
Apply remaining touch ups for patch release
adf64b2 
- Issue #102: Rename root cuda to cuda_bindings
- Issue #145: Explain layout change
- Issue #108: Resolve how to run editable builds
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@vzhurba01 vzhurba01 merged commit fdb64d1 into 11.8.x Oct 11, 2024
@leofang leofang deleted the 11.8.x-test-layout branch October 11, 2024 20:53
leofang
leofang reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vzhurba01! Left two questions.

cuda/cuda/bindings/_bindings/loader.cpp Show resolved Hide resolved
cuda/cuda/bindings/_lib/param_packer.cpp Show resolved Hide resolved
@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Oct 11, 2024
@leofang leofang added this to the cuda-python 12.6.1 & 11.8.4 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang left review comments

Assignees

@vzhurba01 vzhurba01

Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.6.1 & 11.8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@vzhurba01 @leofang