Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the layout change in the release note #145

Closed
leofang opened this issue Oct 10, 2024 · 1 comment
Closed

Explain the layout change in the release note #145

leofang opened this issue Oct 10, 2024 · 1 comment
Assignees
@vzhurba01
Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P0 High priority - Must do!
Milestone
cuda-python 12.6....

Comments

@leofang
Copy link
Member

leofang commented Oct 10, 2024

Right now the entry in our release note is unclear what's changed:

cuda-python/docs_src/source/release/12.6.1-notes.md

Line 6 in 797286b

- Resolve [Issue #90](https://github.com/NVIDIA/cuda-python/issues/90): Use new layout in preperation for cuda-python becoming a metapackage

and it could be confusing because all API references now point to the new layouts only, partly because of the Sphinx limitations (#140).

We should:

  • Reuse text from [EPIC] RFC: cuda namespace cleanup #75 to teach about old vs new locations (ex: cuda.cuda vs cuda.bindings.driver)
  • Emphasize the old paths are still working and this is a bc change
@leofang leofang added documentation Improvements or additions to documentation P0 High priority - Must do! labels Oct 10, 2024
@leofang leofang added this to the cuda-python 12.6.1 & 11.8.4 milestone Oct 10, 2024
@leofang leofang added the cuda.bindings Everything related to the cuda.bindings module label Oct 10, 2024
vzhurba01 added a commit that referenced this issue Oct 11, 2024
@vzhurba01
Apply remaining touch ups for patch release
adf64b2 
- Issue #102: Rename root cuda to cuda_bindings
- Issue #145: Explain layout change
- Issue #108: Resolve how to run editable builds
vzhurba01 added a commit that referenced this issue Oct 11, 2024
@vzhurba01
Apply remaining touch ups for patch release
11a9013 
- Issue #102: Rename root cuda to cuda_bindings
- Issue #145: Explain layout change
- Issue #108: Resolve how to run editable builds
This was referenced Oct 11, 2024
Merged
Merged
@vzhurba01
Copy link
Collaborator

Resolved by MR #159. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vzhurba01 vzhurba01

Labels
cuda.bindings Everything related to the cuda.bindings module documentation Improvements or additions to documentation P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.6.1 & 11.8.4
Development

No branches or pull requests
2 participants
@leofang @vzhurba01