-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate static map examples #407
Merged
PointKernel
merged 8 commits into
NVIDIA:dev
from
PointKernel:migrate-static-map-examples
Dec 19, 2023
Merged
Migrate static map examples #407
PointKernel
merged 8 commits into
NVIDIA:dev
from
PointKernel:migrate-static-map-examples
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointKernel
added
topic: static_map
Issue related to the static_map
type: improvement
Improvement / enhancement to an existing function
labels
Dec 18, 2023
sleeepyjack
reviewed
Dec 19, 2023
sleeepyjack
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: static_map
Issue related to the static_map
type: improvement
Improvement / enhancement to an existing function
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all single map examples to use the new experimental map. It also fixes a bug where bitwise compare should be used to compare sentinel values.