Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate static map examples #407

Merged
merged 8 commits into from
Dec 19, 2023

Conversation

PointKernel
Copy link
Member

@PointKernel PointKernel commented Dec 15, 2023

This PR migrates all single map examples to use the new experimental map. It also fixes a bug where bitwise compare should be used to compare sentinel values.

@PointKernel PointKernel added topic: static_map Issue related to the static_map type: improvement Improvement / enhancement to an existing function labels Dec 18, 2023
@PointKernel PointKernel marked this pull request as ready for review December 18, 2023 18:47
Copy link
Collaborator

@sleeepyjack sleeepyjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@PointKernel PointKernel merged commit d12da95 into NVIDIA:dev Dec 19, 2023
15 checks passed
@PointKernel PointKernel deleted the migrate-static-map-examples branch December 19, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: static_map Issue related to the static_map type: improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants