Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to avoid UB in thrust::reference #2813

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Try to avoid UB in thrust::reference #2813

wants to merge 2 commits into from

Commits on Nov 14, 2024

  1. Try to avoid UB in thrust::reference 

    We were dereferencing a nullptr because we wanted to avoid default constructing a system.

This is obvious UB and prevents us from running the tests with sanitizers, so just default construct the systems.

Addresses NVIDIA#1645
    @miscco
    miscco committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9763535 View commit details
    Browse the repository at this point in the history

  2. Make execute_with_allocator default constructible

    @miscco
    miscco committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5789899 View commit details
    Browse the repository at this point in the history