backport std integer comparison functions to C++11

libcudacxx/include/cuda/std/__utility/cmp.h

@@ -21,6 +21,8 @@
 #endif // no system header
 
 #include <cuda/std/__type_traits/disjunction.h>
+#include <cuda/std/__type_traits/enable_if.h>
+#include <cuda/std/__type_traits/integral_constant.h>
 #include <cuda/std/__type_traits/is_integral.h>
 #include <cuda/std/__type_traits/is_same.h>
 #include <cuda/std/__type_traits/is_signed.h>
@@ -33,37 +35,53 @@ _CCCL_PUSH_MACROS
 
 _LIBCUDACXX_BEGIN_NAMESPACE_STD
 
-#if _CCCL_STD_VER > 2017
+#if _CCCL_STD_VER >= 2014
+
+_CCCL_DIAG_PUSH
+
+// Suppress NVHPC's warnings about signed/unsigned comparisons when -Wsign-compare is specified
+// TODO: find out the warning number
+// _CCCL_DIAG_SUPPRESS_NVHPC()
+
+// Suppress MSVC's warnings about signed/unsigned comparisons
+// C4018: 'token' : signed/unsigned mismatch
+// C4127: conditional expression is constant
+// C4389: 'equality-operator' : signed/unsigned mismatch
+_CCCL_DIAG_SUPPRESS_MSVC(4018 4127 4389)
+
 template <class _Tp, class... _Up>
 struct _IsSameAsAny : _Or<_IsSame<_Tp, _Up>...>
 {};
 
 template <class _Tp>
-concept __is_safe_integral_cmp =
-  is_integral_v<_Tp>
-  && !_IsSameAsAny<_Tp,
-                   bool,
-                   char,
-                   char16_t,
-                   char32_t
+struct __is_safe_integral_cmp
+    : bool_constant<_CCCL_TRAIT(is_integral, _Tp)
+                    && !_IsSameAsAny<_Tp,
+                                     bool,
+                                     char,
+                                     char16_t,
+                                     char32_t
 #  ifndef _LIBCUDACXX_NO_HAS_CHAR8_T
-                   ,
-                   char8_t
+                                     ,
+                                     char8_t
 #  endif
 #  ifndef _LIBCUDACXX_HAS_NO_WIDE_CHARACTERS
-                   ,
-                   wchar_t
+                                     ,
+                                     wchar_t
 #  endif
-                   >::value;
+                                     >::value>
+{};
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_equal(_Tp __t, _Up __u) noexcept
 {
-  if constexpr (is_signed_v<_Tp> == is_signed_v<_Up>)
+  _CCCL_IF_CONSTEXPR (_CCCL_TRAIT(is_signed, _Tp) == _CCCL_TRAIT(is_signed, _Up))
   {
     return __t == __u;
   }
-  else if constexpr (is_signed_v<_Tp>)
+  _CCCL_ELSE_IF_CONSTEXPR (_CCCL_TRAIT(is_signed, _Tp))
   {
     return __t < 0 ? false : make_unsigned_t<_Tp>(__t) == __u;
   }
@@ -73,20 +91,24 @@ _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_equal(_Tp __t, _Up __u) noexcept
   }
 }
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_not_equal(_Tp __t, _Up __u) noexcept
 {
   return !_CUDA_VSTD::cmp_equal(__t, __u);
 }
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_less(_Tp __t, _Up __u) noexcept
 {
-  if constexpr (is_signed_v<_Tp> == is_signed_v<_Up>)
+  _CCCL_IF_CONSTEXPR (_CCCL_TRAIT(is_signed, _Tp) == _CCCL_TRAIT(is_signed, _Up))
   {
     return __t < __u;
   }
-  else if constexpr (is_signed_v<_Tp>)
+  _CCCL_ELSE_IF_CONSTEXPR (_CCCL_TRAIT(is_signed, _Tp))
   {
     return __t < 0 ? true : make_unsigned_t<_Tp>(__t) < __u;
   }
@@ -96,31 +118,42 @@ _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_less(_Tp __t, _Up __u) noexcept
   }
 }
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_greater(_Tp __t, _Up __u) noexcept
 {
   return _CUDA_VSTD::cmp_less(__u, __t);
 }
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_less_equal(_Tp __t, _Up __u) noexcept
 {
   return !_CUDA_VSTD::cmp_greater(__t, __u);
 }
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool cmp_greater_equal(_Tp __t, _Up __u) noexcept
 {
   return !_CUDA_VSTD::cmp_less(__t, __u);
 }
 
-template <__is_safe_integral_cmp _Tp, __is_safe_integral_cmp _Up>
+template <class _Tp,
+          class _Up,
+          enable_if_t<__is_safe_integral_cmp<_Tp>::value && __is_safe_integral_cmp<_Up>::value, int> = 0>
 _LIBCUDACXX_HIDE_FROM_ABI constexpr bool in_range(_Up __u) noexcept
 {
   return _CUDA_VSTD::cmp_less_equal(__u, numeric_limits<_Tp>::max())
       && _CUDA_VSTD::cmp_greater_equal(__u, numeric_limits<_Tp>::min());
 }
-#endif // _CCCL_STD_VER > 2017
+
+_CCCL_DIAG_POP
+
+#endif // _CCCL_STD_VER >= 2014
 
 _LIBCUDACXX_END_NAMESPACE_STD
 

libcudacxx/include/cuda/std/version

@@ -29,6 +29,8 @@
 #  include <ciso646> // otherwise go for the smallest possible header
 #endif
 
+#define __cccl_lib_integer_comparison_functions 202002L
+
 #if _CCCL_STD_VER >= 2014
 #  define __cccl_lib_bit_cast     201806L
 #  define __cccl_lib_chrono_udls  201304L
@@ -174,7 +176,6 @@
 // #   define __cccl_lib_format                             202106L
 // # define __cccl_lib_generic_unordered_lookup             201811L
 // # define __cccl_lib_int_pow2                             202002L
-// # define __cccl_lib_integer_comparison_functions         202002L
 // # define __cccl_lib_interpolate                          201902L
 #  ifdef _CCCL_BUILTIN_IS_CONSTANT_EVALUATED
 #    define __cccl_lib_is_constant_evaluated 201811L

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.cmp_equal/cmp_equal.pass.cpp

@@ -7,12 +7,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
 // template<class T, class U>
-//   constexpr bool cmp_equal(T t, U u) noexcept;         // C++20
+//   constexpr bool cmp_equal(T t, U u) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/limits>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.cmp_greater/cmp_greater.pass.cpp

@@ -6,11 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
-//   constexpr bool cmp_greater(T t, U u) noexcept;       // C++20
+//   constexpr bool cmp_greater(T t, U u) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/limits>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.cmp_greater_equal/cmp_greater_equal.pass.cpp

@@ -6,11 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
-//   constexpr bool cmp_greater_equal(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_greater_equal(T t, U u) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/limits>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.cmp_less/cmp_less.pass.cpp

@@ -6,12 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
 // template<class T, class U>
-//   constexpr bool cmp_less(T t, U u) noexcept;          // C++20
+//   constexpr bool cmp_less(T t, U u) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/limits>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.cmp_less_equal/cmp_less_equal.pass.cpp

@@ -6,11 +6,9 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
-//   constexpr bool cmp_less_equal(T t, U u) noexcept;    // C++20
+//   constexpr bool cmp_less_equal(T t, U u) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/limits>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.cmp_not_equal/cmp_not_equal.pass.cpp

@@ -6,12 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
 // template<class T, class U>
-//   constexpr bool cmp_not_equal(T t, U u) noexcept;     // C++20
+//   constexpr bool cmp_not_equal(T t, U u) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/limits>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.fail.cpp

@@ -6,30 +6,28 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
 // template<class T, class U>
-//   constexpr bool cmp_equal(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_equal(T t, U u) noexcept;
 
 // template<class T, class U>
-//   constexpr bool cmp_not_equal(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_not_equal(T t, U u) noexcept;
 
 // template<class T, class U>
-//   constexpr bool cmp_less(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_less(T t, U u) noexcept;
 
 // template<class T, class U>
-//   constexpr bool cmp_less_equal(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_less_equal(T t, U u) noexcept;
 
 // template<class T, class U>
-//   constexpr bool cmp_greater(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_greater(T t, U u) noexcept;
 
 // template<class T, class U>
-//   constexpr bool cmp_greater_equal(T t, U u) noexcept; // C++20
+//   constexpr bool cmp_greater_equal(T t, U u) noexcept;
 
 // template<class R, class T>
-//   constexpr bool in_range(T t) noexcept;      // C++20
+//   constexpr bool in_range(T t) noexcept;
 
 #include <cuda/std/cstddef>
 #include <cuda/std/utility>

libcudacxx/test/libcudacxx/std/utilities/utility/utility.intcmp/intcmp.in_range/in_range.pass.cpp

@@ -6,12 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03, c++11, c++14, c++17
-
 // <utility>
 
 // template<class R, class T>
-//   constexpr bool in_range(T t) noexcept;               // C++20
+//   constexpr bool in_range(T t) noexcept;
 
 #include <cuda/std/cassert>
 #include <cuda/std/cstdint>