Don't use exact comparison for FP values. #2742

Artem-B · 2024-11-07T19:22:55Z

Fixes the test failure in unoptimized builds, where we do accumulate some error.

Description

The test uses exact FP comparison for the operation results, and it fails in unoptimized builds where exp/log operations are not optimized away, and we accumulate some errors.

closes #2741

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

copy-pr-bot · 2024-11-07T19:22:58Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Fixes the test failure in unoptimized builds, where we do accumulate some error.

miscco

I will look into what the actual standard requirements are but that does indeed look like something that might not be required

miscco · 2024-11-07T19:46:05Z

.../libcudacxx/std/numerics/complex.number/complex.transcendentals/pow_complex_complex.pass.cpp

+        if(real(r) != real(z))
+        {
+          is_about(real(r), real(z));
+        }


We should either completely loosen the assertion or fix the code. I am for loosening it if it is not a required equality

Suggested change

if(real(r) != real(z))

{

is_about(real(r), real(z));

}

is_about(real(r), real(z));

We're comparing pow(i, j) vs exp(j * log(i)). If the compiler does not optimize the comparison away, and we actually have to do exp, log and multiplication, there's no practical way not to lose precision.

If it helps, I can make a list of the values that we happen to trip on right now, and by how much the result happens to be different. The failure I poked at had the result difference of ~1e-18.

Looks like the numeric differences only affect double, but they are pretty widespread:
https://gist.github.com/Artem-B/19807d5e4f2e3efb0e3d6319ebed1809

For whatever reason I'm having trouble reproducing the issue on the host today, so it could be caused by my hacks to debug the issue. The original failure only reported the failure on a GPU. So, let's limit the scope to double on GPU.

miscco · 2024-11-07T19:46:24Z

.../libcudacxx/std/numerics/complex.number/complex.transcendentals/pow_complex_complex.pass.cpp

+        if(imag(r) != imag(z))
+        {
+          is_about(imag(r), imag(z));
+        }


Ditto

Suggested change

if(imag(r) != imag(z))

{

is_about(imag(r), imag(z));

}

is_about(imag(r), imag(z));

miscco · 2024-11-08T13:26:39Z

pre-commit.ci autofix

miscco · 2024-11-08T13:29:28Z

/ok to test

github-actions · 2024-11-08T15:13:50Z

🟩 CI finished in 1h 38m: Pass: 100%/394 | Total: 6d 23h | Avg: 25m 28s | Max: 1h 13m | Hits: 77%/25866

🟩 libcudacxx: Pass: 100%/118 | Total: 1d 09h | Avg: 16m 47s | Max: 1h 13m | Hits: 75%/9500

🟩 cpu
  🟩 amd64              Pass: 100%/110 | Total:  1d 07h | Avg: 17m 01s | Max:  1h 13m | Hits:  75%/9500  
  🟩 arm64              Pass: 100%/8   | Total:  1h 49m | Avg: 13m 40s | Max: 24m 55s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  3h 06m | Avg: 12m 27s | Max: 22m 54s | Hits:  91%/2181  
  🟩 11.8               Pass: 100%/3   | Total: 54m 26s | Avg: 18m 08s | Max: 27m 01s
  🟩 12.5               Pass: 100%/4   | Total:  1h 36m | Avg: 24m 08s | Max: 37m 31s
  🟩 12.6               Pass: 100%/96  | Total:  1d 03h | Avg: 17m 07s | Max:  1h 13m | Hits:  70%/7319  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/12  | Total:  2h 29m | Avg: 12m 28s | Max: 20m 58s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  3h 06m | Avg: 12m 27s | Max: 22m 54s | Hits:  91%/2181  
  🟩 nvcc11.8           Pass: 100%/3   | Total: 54m 26s | Avg: 18m 08s | Max: 27m 01s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  1h 36m | Avg: 24m 08s | Max: 37m 31s
  🟩 nvcc12.6           Pass: 100%/84  | Total:  1d 00h | Avg: 17m 47s | Max:  1h 13m | Hits:  70%/7319  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/12  | Total:  2h 29m | Avg: 12m 28s | Max: 20m 58s
  🟩 nvcc               Pass: 100%/106 | Total:  1d 06h | Avg: 17m 17s | Max:  1h 13m | Hits:  75%/9500  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  1h 25m | Avg: 14m 12s | Max: 22m 50s
  🟩 Clang10            Pass: 100%/3   | Total:  1h 13m | Avg: 24m 34s | Max: 30m 51s
  🟩 Clang11            Pass: 100%/4   | Total:  1h 29m | Avg: 22m 19s | Max: 28m 12s
  🟩 Clang12            Pass: 100%/4   | Total:  1h 11m | Avg: 17m 57s | Max: 28m 55s
  🟩 Clang13            Pass: 100%/4   | Total:  1h 39m | Avg: 24m 46s | Max: 28m 39s
  🟩 Clang14            Pass: 100%/4   | Total:  1h 07m | Avg: 16m 46s | Max: 27m 40s
  🟩 Clang15            Pass: 100%/4   | Total:  1h 02m | Avg: 15m 37s | Max: 27m 28s
  🟩 Clang16            Pass: 100%/4   | Total:  1h 22m | Avg: 20m 41s | Max: 30m 18s
  🟩 Clang17            Pass: 100%/4   | Total: 45m 30s | Avg: 11m 22s | Max: 26m 09s
  🟩 Clang18            Pass: 100%/18  | Total:  4h 58m | Avg: 16m 34s | Max:  1h 13m
  🟩 GCC6               Pass: 100%/2   | Total:  7m 42s | Avg:  3m 51s | Max:  5m 12s
  🟩 GCC7               Pass: 100%/6   | Total:  1h 49m | Avg: 18m 10s | Max: 25m 37s
  🟩 GCC8               Pass: 100%/6   | Total:  1h 44m | Avg: 17m 20s | Max: 24m 53s
  🟩 GCC9               Pass: 100%/6   | Total:  1h 03m | Avg: 10m 31s | Max: 26m 50s
  🟩 GCC10              Pass: 100%/4   | Total: 56m 58s | Avg: 14m 14s | Max: 26m 48s
  🟩 GCC11              Pass: 100%/7   | Total:  1h 40m | Avg: 14m 25s | Max: 28m 16s
  🟩 GCC12              Pass: 100%/4   | Total:  1h 24m | Avg: 21m 06s | Max: 29m 35s
  🟩 GCC13              Pass: 100%/17  | Total:  3h 28m | Avg: 12m 14s | Max: 28m 17s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 15m | Avg: 25m 18s | Max: 31m 04s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 22m 53s | Avg: 22m 53s | Max: 22m 53s | Hits:  91%/2181  
  🟩 MSVC14.29          Pass: 100%/2   | Total: 31m 47s | Avg: 15m 53s | Max: 16m 46s | Hits:  91%/4725  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 45m 12s | Avg: 45m 12s | Max: 45m 12s | Hits:  32%/2594  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  1h 36m | Avg: 24m 08s | Max: 37m 31s
🟩 cxx_family
  🟩 Clang              Pass: 100%/55  | Total: 16h 15m | Avg: 17m 44s | Max:  1h 13m
  🟩 GCC                Pass: 100%/52  | Total: 12h 14m | Avg: 14m 07s | Max: 29m 35s
  🟩 Intel              Pass: 100%/3   | Total:  1h 15m | Avg: 25m 18s | Max: 31m 04s
  🟩 MSVC               Pass: 100%/4   | Total:  1h 39m | Avg: 24m 58s | Max: 45m 12s | Hits:  75%/9500  
  🟩 NVHPC              Pass: 100%/4   | Total:  1h 36m | Avg: 24m 08s | Max: 37m 31s
🟩 gpu
  🟩 v100               Pass: 100%/118 | Total:  1d 09h | Avg: 16m 47s | Max:  1h 13m | Hits:  75%/9500  
🟩 jobs
  🟩 Build              Pass: 100%/110 | Total:  1d 05h | Avg: 16m 05s | Max: 45m 12s | Hits:  75%/9500  
  🟩 NVRTC              Pass: 100%/4   | Total:  1h 37m | Avg: 24m 19s | Max: 28m 17s
  🟩 Test               Pass: 100%/3   | Total:  1h 52m | Avg: 37m 20s | Max:  1h 13m
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  1m 55s | Avg:  1m 55s | Max:  1m 55s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total: 54m 26s | Avg: 18m 08s | Max: 27m 01s
  🟩 90                 Pass: 100%/4   | Total: 42m 22s | Avg: 10m 35s | Max: 12m 07s
  🟩 90a                Pass: 100%/8   | Total:  1h 02m | Avg:  7m 52s | Max: 13m 33s
🟩 std
  🟩 11                 Pass: 100%/32  | Total:  5h 13m | Avg:  9m 46s | Max: 22m 50s
  🟩 14                 Pass: 100%/32  | Total:  8h 43m | Avg: 16m 21s | Max: 30m 39s | Hits:  91%/4465  
  🟩 17                 Pass: 100%/30  | Total: 11h 26m | Avg: 22m 53s | Max: 37m 31s | Hits:  92%/2441  
  🟩 20                 Pass: 100%/23  | Total:  7h 37m | Avg: 19m 52s | Max:  1h 13m | Hits:  32%/2594

🟩 cub: Pass: 100%/110 | Total: 3d 05h | Avg: 42m 24s | Max: 1h 12m | Hits: 66%/2948

🟩 cpu
  🟩 amd64              Pass: 100%/102 | Total:  2d 23h | Avg: 42m 09s | Max:  1h 12m | Hits:  66%/2948  
  🟩 arm64              Pass: 100%/8   | Total:  6h 04m | Avg: 45m 30s | Max:  1h 03m
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  8h 40m | Avg: 34m 43s | Max: 49m 30s | Hits:  66%/737   
  🟩 11.8               Pass: 100%/3   | Total:  2h 33m | Avg: 51m 16s | Max:  1h 12m
  🟩 12.5               Pass: 100%/4   | Total:  4h 03m | Avg:  1h 00m | Max:  1h 07m
  🟩 12.6               Pass: 100%/88  | Total:  2d 14h | Avg: 42m 34s | Max:  1h 10m | Hits:  66%/2211  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  2h 53m | Avg: 43m 17s | Max: 58m 51s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  8h 40m | Avg: 34m 43s | Max: 49m 30s | Hits:  66%/737   
  🟩 nvcc11.8           Pass: 100%/3   | Total:  2h 33m | Avg: 51m 16s | Max:  1h 12m
  🟩 nvcc12.5           Pass: 100%/4   | Total:  4h 03m | Avg:  1h 00m | Max:  1h 07m
  🟩 nvcc12.6           Pass: 100%/84  | Total:  2d 11h | Avg: 42m 31s | Max:  1h 10m | Hits:  66%/2211  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total:  2h 53m | Avg: 43m 17s | Max: 58m 51s
  🟩 nvcc               Pass: 100%/106 | Total:  3d 02h | Avg: 42m 22s | Max:  1h 12m | Hits:  66%/2948  
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  5h 03m | Avg: 50m 30s | Max: 55m 55s
  🟩 Clang10            Pass: 100%/3   | Total:  2h 37m | Avg: 52m 38s | Max: 54m 12s
  🟩 Clang11            Pass: 100%/4   | Total:  3h 48m | Avg: 57m 06s | Max: 57m 47s
  🟩 Clang12            Pass: 100%/4   | Total:  3h 32m | Avg: 53m 09s | Max: 56m 21s
  🟩 Clang13            Pass: 100%/4   | Total:  3h 31m | Avg: 52m 50s | Max: 56m 06s
  🟩 Clang14            Pass: 100%/4   | Total:  2h 39m | Avg: 39m 52s | Max: 51m 19s
  🟩 Clang15            Pass: 100%/4   | Total:  2h 42m | Avg: 40m 44s | Max: 51m 44s
  🟩 Clang16            Pass: 100%/4   | Total:  2h 47m | Avg: 41m 52s | Max: 56m 35s
  🟩 Clang17            Pass: 100%/4   | Total:  3h 04m | Avg: 46m 02s | Max:  1h 10m
  🟩 Clang18            Pass: 100%/11  | Total:  7h 32m | Avg: 41m 09s | Max:  1h 03m
  🟩 GCC6               Pass: 100%/2   | Total: 53m 07s | Avg: 26m 33s | Max: 49m 16s
  🟩 GCC7               Pass: 100%/6   | Total:  3h 29m | Avg: 34m 58s | Max: 55m 05s
  🟩 GCC8               Pass: 100%/6   | Total:  3h 29m | Avg: 34m 50s | Max: 56m 28s
  🟩 GCC9               Pass: 100%/6   | Total:  3h 27m | Avg: 34m 38s | Max: 52m 49s
  🟩 GCC10              Pass: 100%/4   | Total:  2h 55m | Avg: 43m 47s | Max: 57m 23s
  🟩 GCC11              Pass: 100%/7   | Total:  5h 30m | Avg: 47m 09s | Max:  1h 12m
  🟩 GCC12              Pass: 100%/4   | Total:  2h 42m | Avg: 40m 34s | Max: 51m 44s
  🟩 GCC13              Pass: 100%/16  | Total:  8h 07m | Avg: 30m 27s | Max: 58m 22s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  2h 01m | Avg: 40m 29s | Max: 58m 38s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 49m 30s | Avg: 49m 30s | Max: 49m 30s | Hits:  66%/737   
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 54m | Avg: 57m 25s | Max: 59m 54s | Hits:  66%/1474  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 59m 51s | Avg: 59m 51s | Max: 59m 51s | Hits:  66%/737   
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  4h 03m | Avg:  1h 00m | Max:  1h 07m
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total:  1d 13h | Avg: 46m 40s | Max:  1h 10m
  🟩 GCC                Pass: 100%/51  | Total:  1d 06h | Avg: 35m 58s | Max:  1h 12m
  🟩 Intel              Pass: 100%/3   | Total:  2h 01m | Avg: 40m 29s | Max: 58m 38s
  🟩 MSVC               Pass: 100%/4   | Total:  3h 44m | Avg: 56m 03s | Max: 59m 54s | Hits:  66%/2948  
  🟩 NVHPC              Pass: 100%/4   | Total:  4h 03m | Avg:  1h 00m | Max:  1h 07m
🟩 gpu
  🟩 v100               Pass: 100%/110 | Total:  3d 05h | Avg: 42m 24s | Max:  1h 12m | Hits:  66%/2948  
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total:  3d 02h | Avg: 43m 39s | Max:  1h 12m | Hits:  66%/2948  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 22m 28s | Avg: 22m 28s | Max: 22m 28s
  🟩 GraphCapture       Pass: 100%/1   | Total: 18m 42s | Avg: 18m 42s | Max: 18m 42s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 16m | Avg: 25m 30s | Max: 41m 33s
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 32m | Avg: 30m 56s | Max: 51m 29s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  2h 33m | Avg: 51m 16s | Max:  1h 12m
  🟩 90a                Pass: 100%/4   | Total:  1h 17m | Avg: 19m 23s | Max: 25m 06s
🟩 std
  🟩 11                 Pass: 100%/30  | Total: 10h 31m | Avg: 21m 02s | Max: 57m 47s
  🟩 14                 Pass: 100%/29  | Total:  1d 01h | Avg: 51m 58s | Max:  1h 12m | Hits:  66%/1474  
  🟩 17                 Pass: 100%/27  | Total: 23h 51m | Avg: 53m 00s | Max:  1h 10m | Hits:  66%/737   
  🟩 20                 Pass: 100%/24  | Total: 18h 14m | Avg: 45m 35s | Max:  1h 07m | Hits:  66%/737

🟩 thrust: Pass: 100%/109 | Total: 2d 03h | Avg: 28m 16s | Max: 1h 03m | Hits: 82%/13180

🟩 cpu
  🟩 amd64              Pass: 100%/101 | Total:  1d 23h | Avg: 28m 30s | Max:  1h 03m | Hits:  82%/13180 
  🟩 arm64              Pass: 100%/8   | Total:  3h 23m | Avg: 25m 29s | Max: 38m 28s
🟩 ctk
  🟩 11.1               Pass: 100%/15  | Total:  6h 09m | Avg: 24m 39s | Max: 53m 44s | Hits:  77%/2636  
  🟩 11.8               Pass: 100%/3   | Total:  1h 29m | Avg: 29m 55s | Max: 43m 59s
  🟩 12.5               Pass: 100%/4   | Total:  3h 37m | Avg: 54m 27s | Max: 57m 19s
  🟩 12.6               Pass: 100%/87  | Total:  1d 16h | Avg: 27m 38s | Max:  1h 03m | Hits:  83%/10544 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/4   | Total:  1h 31m | Avg: 22m 59s | Max: 29m 14s
  🟩 nvcc11.1           Pass: 100%/15  | Total:  6h 09m | Avg: 24m 39s | Max: 53m 44s | Hits:  77%/2636  
  🟩 nvcc11.8           Pass: 100%/3   | Total:  1h 29m | Avg: 29m 55s | Max: 43m 59s
  🟩 nvcc12.5           Pass: 100%/4   | Total:  3h 37m | Avg: 54m 27s | Max: 57m 19s
  🟩 nvcc12.6           Pass: 100%/83  | Total:  1d 14h | Avg: 27m 52s | Max:  1h 03m | Hits:  83%/10544 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/4   | Total:  1h 31m | Avg: 22m 59s | Max: 29m 14s
  🟩 nvcc               Pass: 100%/105 | Total:  2d 01h | Avg: 28m 28s | Max:  1h 03m | Hits:  82%/13180 
🟩 cxx
  🟩 Clang9             Pass: 100%/6   | Total:  3h 06m | Avg: 31m 05s | Max: 36m 11s
  🟩 Clang10            Pass: 100%/3   | Total:  1h 40m | Avg: 33m 37s | Max: 37m 27s
  🟩 Clang11            Pass: 100%/4   | Total:  2h 10m | Avg: 32m 39s | Max: 36m 29s
  🟩 Clang12            Pass: 100%/4   | Total:  2h 08m | Avg: 32m 01s | Max: 36m 26s
  🟩 Clang13            Pass: 100%/4   | Total:  2h 12m | Avg: 33m 00s | Max: 36m 22s
  🟩 Clang14            Pass: 100%/4   | Total:  1h 41m | Avg: 25m 25s | Max: 34m 27s
  🟩 Clang15            Pass: 100%/4   | Total:  1h 51m | Avg: 27m 45s | Max: 37m 29s
  🟩 Clang16            Pass: 100%/4   | Total:  1h 48m | Avg: 27m 07s | Max: 35m 58s
  🟩 Clang17            Pass: 100%/4   | Total:  1h 45m | Avg: 26m 27s | Max: 34m 53s
  🟩 Clang18            Pass: 100%/11  | Total:  4h 07m | Avg: 22m 29s | Max: 32m 43s
  🟩 GCC6               Pass: 100%/2   | Total: 37m 02s | Avg: 18m 31s | Max: 33m 08s
  🟩 GCC7               Pass: 100%/6   | Total:  2h 16m | Avg: 22m 42s | Max: 34m 25s
  🟩 GCC8               Pass: 100%/6   | Total:  2h 16m | Avg: 22m 43s | Max: 35m 10s
  🟩 GCC9               Pass: 100%/6   | Total:  2h 24m | Avg: 24m 03s | Max: 37m 37s
  🟩 GCC10              Pass: 100%/4   | Total:  1h 53m | Avg: 28m 25s | Max: 36m 42s
  🟩 GCC11              Pass: 100%/7   | Total:  3h 32m | Avg: 30m 22s | Max: 46m 17s
  🟩 GCC12              Pass: 100%/4   | Total:  1h 52m | Avg: 28m 03s | Max: 38m 05s
  🟩 GCC13              Pass: 100%/14  | Total:  4h 24m | Avg: 18m 55s | Max: 41m 52s
  🟩 Intel2023.2.0      Pass: 100%/3   | Total:  1h 36m | Avg: 32m 13s | Max: 45m 21s
  🟩 MSVC14.16          Pass: 100%/1   | Total: 53m 44s | Avg: 53m 44s | Max: 53m 44s | Hits:  77%/2636  
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 59m | Avg: 59m 50s | Max:  1h 00m | Hits:  77%/5272  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  1h 24m | Avg: 42m 26s | Max:  1h 03m | Hits:  88%/5272  
  🟩 NVHPC24.7          Pass: 100%/4   | Total:  3h 37m | Avg: 54m 27s | Max: 57m 19s
🟩 cxx_family
  🟩 Clang              Pass: 100%/48  | Total: 22h 32m | Avg: 28m 10s | Max: 37m 29s
  🟩 GCC                Pass: 100%/49  | Total: 19h 17m | Avg: 23m 36s | Max: 46m 17s
  🟩 Intel              Pass: 100%/3   | Total:  1h 36m | Avg: 32m 13s | Max: 45m 21s
  🟩 MSVC               Pass: 100%/5   | Total:  4h 18m | Avg: 51m 39s | Max:  1h 03m | Hits:  82%/13180 
  🟩 NVHPC              Pass: 100%/4   | Total:  3h 37m | Avg: 54m 27s | Max: 57m 19s
🟩 gpu
  🟩 v100               Pass: 100%/109 | Total:  2d 03h | Avg: 28m 16s | Max:  1h 03m | Hits:  82%/13180 
🟩 jobs
  🟩 Build              Pass: 100%/102 | Total:  2d 01h | Avg: 29m 19s | Max:  1h 03m | Hits:  77%/10544 
  🟩 TestCPU            Pass: 100%/4   | Total: 46m 34s | Avg: 11m 38s | Max: 21m 40s | Hits:  99%/2636  
  🟩 TestGPU            Pass: 100%/3   | Total: 44m 40s | Avg: 14m 53s | Max: 20m 50s
🟩 sm
  🟩 60;70;80;90        Pass: 100%/3   | Total:  1h 29m | Avg: 29m 55s | Max: 43m 59s
  🟩 90a                Pass: 100%/4   | Total:  1h 06m | Avg: 16m 41s | Max: 21m 52s
🟩 std
  🟩 11                 Pass: 100%/30  | Total:  5h 42m | Avg: 11m 24s | Max: 50m 54s
  🟩 14                 Pass: 100%/29  | Total: 17h 17m | Avg: 35m 46s | Max: 59m 14s | Hits:  77%/5272  
  🟩 17                 Pass: 100%/27  | Total: 16h 14m | Avg: 36m 05s | Max:  1h 00m | Hits:  77%/2636  
  🟩 20                 Pass: 100%/23  | Total: 12h 08m | Avg: 31m 40s | Max:  1h 03m | Hits:  88%/5272

🟩 cudax: Pass: 100%/54 | Total: 4h 40m | Avg: 5m 11s | Max: 18m 05s | Hits: 87%/238

🟩 cpu
  🟩 amd64              Pass: 100%/50  | Total:  4h 26m | Avg:  5m 19s | Max: 18m 05s | Hits:  87%/238   
  🟩 arm64              Pass: 100%/4   | Total: 14m 28s | Avg:  3m 37s | Max:  3m 56s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total:  1h 38m | Avg:  5m 11s | Max: 17m 54s | Hits:  87%/119   
  🟩 12.5               Pass: 100%/2   | Total: 11m 55s | Avg:  5m 57s | Max:  6m 05s
  🟩 12.6               Pass: 100%/33  | Total:  2h 50m | Avg:  5m 09s | Max: 18m 05s | Hits:  87%/119   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total:  1h 38m | Avg:  5m 11s | Max: 17m 54s | Hits:  87%/119   
  🟩 nvcc12.5           Pass: 100%/2   | Total: 11m 55s | Avg:  5m 57s | Max:  6m 05s
  🟩 nvcc12.6           Pass: 100%/33  | Total:  2h 50m | Avg:  5m 09s | Max: 18m 05s | Hits:  87%/119   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/54  | Total:  4h 40m | Avg:  5m 11s | Max: 18m 05s | Hits:  87%/238   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  7m 51s | Avg:  3m 55s | Max:  4m 24s
  🟩 Clang10            Pass: 100%/2   | Total:  8m 07s | Avg:  4m 03s | Max:  4m 07s
  🟩 Clang11            Pass: 100%/4   | Total: 14m 10s | Avg:  3m 32s | Max:  3m 57s
  🟩 Clang12            Pass: 100%/4   | Total: 14m 01s | Avg:  3m 30s | Max:  3m 38s
  🟩 Clang13            Pass: 100%/4   | Total: 14m 38s | Avg:  3m 39s | Max:  3m 58s
  🟩 Clang14            Pass: 100%/4   | Total: 28m 55s | Avg:  7m 13s | Max: 17m 54s
  🟩 Clang15            Pass: 100%/2   | Total:  7m 57s | Avg:  3m 58s | Max:  4m 05s
  🟩 Clang16            Pass: 100%/4   | Total: 14m 34s | Avg:  3m 38s | Max:  3m 47s
  🟩 Clang17            Pass: 100%/2   | Total:  7m 35s | Avg:  3m 47s | Max:  3m 55s
  🟩 Clang18            Pass: 100%/2   | Total: 21m 13s | Avg: 10m 36s | Max: 17m 25s
  🟩 GCC9               Pass: 100%/2   | Total:  6m 54s | Avg:  3m 27s | Max:  3m 38s
  🟩 GCC10              Pass: 100%/4   | Total: 14m 06s | Avg:  3m 31s | Max:  3m 59s
  🟩 GCC11              Pass: 100%/4   | Total: 14m 43s | Avg:  3m 40s | Max:  3m 57s
  🟩 GCC12              Pass: 100%/7   | Total:  1h 06m | Avg:  9m 29s | Max: 18m 05s
  🟩 GCC13              Pass: 100%/3   | Total: 10m 42s | Avg:  3m 34s | Max:  3m 56s
  🟩 MSVC14.36          Pass: 100%/1   | Total:  8m 19s | Avg:  8m 19s | Max:  8m 19s | Hits:  87%/119   
  🟩 MSVC14.39          Pass: 100%/1   | Total:  8m 28s | Avg:  8m 28s | Max:  8m 28s | Hits:  87%/119   
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 11m 55s | Avg:  5m 57s | Max:  6m 05s
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  2h 19m | Avg:  4m 38s | Max: 17m 54s
  🟩 GCC                Pass: 100%/20  | Total:  1h 52m | Avg:  5m 38s | Max: 18m 05s
  🟩 MSVC               Pass: 100%/2   | Total: 16m 47s | Avg:  8m 23s | Max:  8m 28s | Hits:  87%/238   
  🟩 NVHPC              Pass: 100%/2   | Total: 11m 55s | Avg:  5m 57s | Max:  6m 05s
🟩 gpu
  🟩 v100               Pass: 100%/54  | Total:  4h 40m | Avg:  5m 11s | Max: 18m 05s | Hits:  87%/238   
🟩 jobs
  🟩 Build              Pass: 100%/49  | Total:  3h 12m | Avg:  3m 56s | Max:  8m 28s | Hits:  87%/238   
  🟩 Test               Pass: 100%/5   | Total:  1h 27m | Avg: 17m 31s | Max: 18m 05s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  3m 13s | Avg:  3m 13s | Max:  3m 13s
  🟩 90a                Pass: 100%/1   | Total:  3m 20s | Avg:  3m 20s | Max:  3m 20s
🟩 std
  🟩 17                 Pass: 100%/29  | Total:  2h 15m | Avg:  4m 40s | Max: 18m 05s
  🟩 20                 Pass: 100%/25  | Total:  2h 25m | Avg:  5m 48s | Max: 17m 54s | Hits:  87%/238

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 05s | Avg: 5m 02s | Max: 7m 43s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 ctk
  🟩 12.6               Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 gpu
  🟩 v100               Pass: 100%/2   | Total: 10m 05s | Avg:  5m 02s | Max:  7m 43s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 22s | Avg:  2m 22s | Max:  2m 22s
  🟩 Test               Pass: 100%/1   | Total:  7m 43s | Avg:  7m 43s | Max:  7m 43s

🟩 python: Pass: 100%/1 | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 ctk
  🟩 12.6               Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 gpu
  🟩 v100               Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
	CUB
	Thrust
	CUDA Experimental
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 394)

#	Runner
326	`linux-amd64-cpu16`
28	`linux-arm64-cpu16`
25	`linux-amd64-gpu-v100-latest-1`
15	`windows-amd64-cpu16`

Artem-B requested review from a team as code owners November 7, 2024 19:22

Artem-B requested review from wmaxey and gonidelis November 7, 2024 19:22

Don't use exact comparison for FP values.

f97febf

Fixes the test failure in unoptimized builds, where we do accumulate some error.

Artem-B force-pushed the fptest branch from f0dd056 to f97febf Compare November 7, 2024 19:24

miscco reviewed Nov 7, 2024

View reviewed changes

[pre-commit.ci] auto code formatting

03495a1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Don't use exact comparison for FP values. #2742

Don't use exact comparison for FP values. #2742

Artem-B commented Nov 7, 2024

copy-pr-bot bot commented Nov 7, 2024

miscco left a comment

miscco Nov 7, 2024

Artem-B Nov 7, 2024

Artem-B Nov 7, 2024

Artem-B Nov 7, 2024

miscco Nov 7, 2024

miscco commented Nov 8, 2024

miscco commented Nov 8, 2024

github-actions bot commented Nov 8, 2024

🟩 libcudacxx: Pass: 100%/118 | Total: 1d 09h | Avg: 16m 47s | Max: 1h 13m | Hits: 75%/9500

🟩 cub: Pass: 100%/110 | Total: 3d 05h | Avg: 42m 24s | Max: 1h 12m | Hits: 66%/2948

🟩 thrust: Pass: 100%/109 | Total: 2d 03h | Avg: 28m 16s | Max: 1h 03m | Hits: 82%/13180

🟩 cudax: Pass: 100%/54 | Total: 4h 40m | Avg: 5m 11s | Max: 18m 05s | Hits: 87%/238

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 05s | Avg: 5m 02s | Max: 7m 43s

🟩 python: Pass: 100%/1 | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 394)

Don't use exact comparison for FP values. #2742

Are you sure you want to change the base?

Don't use exact comparison for FP values. #2742

Conversation

Artem-B commented Nov 7, 2024

Description

Checklist

copy-pr-bot bot commented Nov 7, 2024

miscco left a comment

Choose a reason for hiding this comment

miscco Nov 7, 2024

Choose a reason for hiding this comment

Artem-B Nov 7, 2024

Choose a reason for hiding this comment

Artem-B Nov 7, 2024

Choose a reason for hiding this comment

Artem-B Nov 7, 2024

Choose a reason for hiding this comment

miscco Nov 7, 2024

Choose a reason for hiding this comment

miscco commented Nov 8, 2024

miscco commented Nov 8, 2024

github-actions bot commented Nov 8, 2024

🟩 libcudacxx: Pass: 100%/118 | Total: 1d 09h | Avg: 16m 47s | Max: 1h 13m | Hits: 75%/9500

🟩 cub: Pass: 100%/110 | Total: 3d 05h | Avg: 42m 24s | Max: 1h 12m | Hits: 66%/2948

🟩 thrust: Pass: 100%/109 | Total: 2d 03h | Avg: 28m 16s | Max: 1h 03m | Hits: 82%/13180

🟩 cudax: Pass: 100%/54 | Total: 4h 40m | Avg: 5m 11s | Max: 18m 05s | Hits: 87%/238

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 10m 05s | Avg: 5m 02s | Max: 7m 43s

🟩 python: Pass: 100%/1 | Total: 15m 57s | Avg: 15m 57s | Max: 15m 57s

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 394)