Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make progress printer compatible with PTL v2.5.0 #11779

Merged
merged 1 commit into from
Jan 8, 2025
Merged

make progress printer compatible with PTL v2.5.0 #11779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo/lightning/pytorch/callbacks/progress_printer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def on_sanity_check_end(self, *_: Any) -> None:
self._validation_description = "Validation"

@override
def on_train_epoch_start(self, trainer, *_):
def on_train_start(self, trainer, *_):
if trainer.max_steps > 0:
# while resuming from a ckpt use trainer.max_steps as the total for progress bar as trainer.num_training_batches
# is truncated to max_steps - step being resumed at
Expand Down
Loading