Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/colang 2/fix undefined flow continuation #780

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

schuellc-nvidia
Copy link
Collaborator

@schuellc-nvidia schuellc-nvidia commented Sep 27, 2024

This fixes an issues to enable designing with undefined user intent flows such that they are awaited an triggered successfully if the flow 'continuation on undefined flow' is activated.

@schuellc-nvidia schuellc-nvidia force-pushed the fix/colang-2/fix-undefined-flow-continuation branch from 9705620 to a6c8580 Compare October 1, 2024 11:55
Copy link
Collaborator

@Pouyanpi Pouyanpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schuellc-nvidia, LGTM!

I don't know much about your testing process. But It would be great to have a test that fails with current version which this PR resolves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants