-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(library): Update Cleanlab's return type #768
base: develop
Are you sure you want to change the base?
Conversation
Hi @Pouyanpi , can you give this a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @AshishSardana, Thanks for the PR!
You just need to sign your commits then we can merge.
@AshishSardana, I can see that your commit is not gpg signed, you can also verify that by git log --show-signature You can see how it differs from its prev commits. Please also rebase your branch onto the latest develop branch as some tests are failing due to the latest changes of the repo. |
…o package Signed-off-by: Ashish Sardana <[email protected]>
f46a82c
to
4a59b18
Compare
@Pouyanpi thank you for our suggestions! i've setup GPG, signed my commits and rebased my branch onto latest develop. |
@Pouyanpi all the checks pass & the PR is ready to be merged. |
Cleanlab's latest release (v2.5 on 09/20) to
cleanlab-studio
pypi package updates the return type ofget_trustworthiness_score_async()
method fromfloat
totypeddict
. Therefore, thetrustworthiness_score
is indexed out from the typed dict.The fix is verified after updating
pip install -U cleanlab-studio
.