fix(library): Update Cleanlab's return type #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Pouyanpi , can you give this a quick look? |
Pouyanpi
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
LGTM @AshishSardana, Thanks for the PR!
You just need to sign your commits then we can merge.
|
I did sign the commit on this PR, manually. I've been using the same signing technique for older commits/PRs. 
|
|
@AshishSardana, I can see that your commit is not gpg signed, you can also verify that by git log --show-signatureYou can see how it differs from its prev commits. Please also rebase your branch onto the latest develop branch as some tests are failing due to the latest changes of the repo. |
…o package Signed-off-by: Ashish Sardana <[email protected]>
AshishSardana
force-pushed
the
update-cleanlab
branch
from
f46a82c
to
4a59b18
Compare
|
@Pouyanpi thank you for our suggestions! i've setup GPG, signed my commits and rebased my branch onto latest develop. |
|
@Pouyanpi all the checks pass & the PR is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanlab's latest release (v2.5 on 09/20) to
cleanlab-studiopypi package updates the return type ofget_trustworthiness_score_async()method fromfloattotypeddict. Therefore, thetrustworthiness_scoreis indexed out from the typed dict.The fix is verified after updating
pip install -U cleanlab-studio.