-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new RAG Chatbot example with llamaGuard and Alignscore integration #720
base: develop
Are you sure you want to change the base?
Conversation
@drazvan for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @abodhankar!
Generally, looks good. However, there are a few issues to solve before we'd be able to merge:
- currently there is no documentation
- the code is not a bot, so it should not be placed under
examples/bots
- given there's also an ingestion part, this would be a better fit for a notebook; the notebook would explain the goal, the ingestion part, and then adding the guardrails; you can place it in
examples/notebooks
; - the config itself (without the python files) can be placed under
examples/configs
; the notebook can copy it from there; - including a 200 pages PDF in the repository is not recommended; can this be downloaded dynamically from somewhere? You can add this part to the notebook as well.
- only one commit seems to be signed. Please configure signing the commits as per the contributing guidelines, and then rebase on top of the
develop
branch. - make sure you link to the documentation about setting up the AlignScore server.
I'll review again once the above points have been addressed.
a49a29b
to
75118dd
Compare
a40b98d
to
eaf9496
Compare
@drazvan Made all the changes as per request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that, langchain_nvidia_ai_endpoints
most recent version only supports langchain 3 which is not currently supported by NeMo Guardrails. We will have it merged to the develop branch latest this week.
@Pouyanpi the example was built using the following dependencies - |
@abodhankar, having the Please run You can then run: pre-commit run --all-files The pipeline is failing because of this. Finally, make sure to sign all of your commits. If you have GPG configured, the easiest way would be to run the following after checking out this branch: git rebase --exec 'git commit --amend --no-edit -n -S' -i origin/develop Also make sure that the it works with the latest state of develop branch (it should). I will merge when the pipeline pass and the commits are signed. Thank you! |
LlamaGuard Alignscore Integration with RAG