Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable SP in mixtral-8x7b #309

Merged
merged 3 commits into from
Aug 8, 2024
Merged

enable SP in mixtral-8x7b #309

merged 3 commits into from
Aug 8, 2024

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented May 6, 2024

Avoid triggering raise ValueError( ValueError: When using expert parallelism and tensor parallelism, sequence parallelism must be used, since both EP & TP are enabled.

@akoumpa akoumpa marked this pull request as ready for review May 6, 2024 16:53
@akoumpa akoumpa self-assigned this May 7, 2024
@akoumpa akoumpa requested a review from dimapihtar May 7, 2024 01:45
akoumpa added 2 commits August 7, 2024 10:15
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa force-pushed the akoumparouli/fix_mixtral_sp branch from 09a389d to 3b03d0c Compare August 7, 2024 17:21
@akoumpa
Copy link
Member Author

akoumpa commented Aug 7, 2024

Also enabled sequence_parallel for mixtral & mistrla

Copy link
Collaborator

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@akoumpa akoumpa merged commit 2768c75 into main Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants