Python: Fixed wheel building on windows by adding path to included header files. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanramos-nvidia
pushed a commit
that referenced
this pull request
Nov 19, 2024
1. Redundant code removed 2. Include the C API headers in source distribution This completely fixes #87
|
Thank you for your submission. We have resolved it another way on the dev branch in commit 32ded0e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80 and other build issues. No need to set C_INCLUDE_PATH=../c/include/ since we automatically add it to the paths (cross platform).
This allows it to be used like a typical python dependency as long as the CUDA include paths are already setup (e.g. if someone already compiled a CUDA example).