Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.5] Allow JobAPI wrapper customization #2988

Merged
merged 3 commits into from
Oct 4, 2024
Merged

[2.5] Allow JobAPI wrapper customization #2988

merged 3 commits into from
Oct 4, 2024

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Cherry-pick:

#2983 #2984 #2985

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh
Pass components into script runner (NVIDIA#2983)
80b611c
@YuanTingHsieh
Fix tf model persistor and tf model (NVIDIA#2984)
56ee91b 
* add missing filter id arg in tf model persistor

* Update TFModel

* Address comment
@YuanTingHsieh
Allow customization of BaseFedJob (NVIDIA#2985)
af5d60b 
* Add CommonComponentsJob

* Fix format

* Address comments

* Fix issue
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit c868367 into NVIDIA:2.5 Oct 4, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the allow_customization_25 branch October 4, 2024 01:15
@YuanTingHsieh YuanTingHsieh linked an issue Oct 7, 2024 that may be closed by this pull request
Expose negate_key_metric argument in Job API. #2585
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYangster SYangster SYangster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose negate_key_metric argument in Job API.
2 participants
@YuanTingHsieh @SYangster