[2.6] Enhance launcher executor #2744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuanTingHsieh
force-pushed
the
enhance_launcher_executor_and_subprocess_launcher
branch
from
02adcf3
to
a16b814
Compare
YuanTingHsieh
changed the title
YuanTingHsieh
changed the title
yanchengnv
requested changes
Aug 12, 2024
| @@ -242,13 +243,15 @@ def _initialize_external_execution( | |||
| abort_signal.trigger("launch task failed") | |||
| return False | |||
|
|
|||
| self.log_info(fl_ctx, f"External execution for task ({task_name}) is launched.") | |||
| self.log_info(fl_ctx, f"launcher launch_task for ({task_name}) succeed.") | |||
There was a problem hiding this comment.
Improve the log message:
Launcher successfully launched task {task_name}.
| # wait for external execution to set up their pipe_handler | ||
| setup_success = self._wait_external_setup(task_name, fl_ctx, abort_signal) | ||
| if not setup_success: | ||
| self.log_error(fl_ctx, "External execution set up failed.") | ||
| abort_signal.trigger("External execution set up failed.") | ||
| error = f"External execution set up for task ({task_name}) failed." |
There was a problem hiding this comment.
Improve error test:
Failed external setup for task {task_name}.
| return False | ||
| self.log_info(fl_ctx, f"External execution set up for task ({task_name}) succeed.") |
There was a problem hiding this comment.
Improve log message:
External setup for task ({task_name}) succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
./runtest.sh.