-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vertical xgb examples for gpu support #1977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Make sure you tested this in Multi-GPU
My machine only has 1 gpu, and I'm having issues building xgboost with nccl from source on our shared multi-gpu DGX due to outdated software, cuda etc. For this pr I was referencing the changes Rong made but I can mark as draft for now until we get the multi-gpu testing working. |
369bf11
to
d9b1cff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes LGTM.
We need to rebase on main and make sure these examples work.
6834a2a
to
855b18e
Compare
855b18e
to
834f9cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
42d844c
to
1773a44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/build |
0037e24
to
fb9a801
Compare
/build |
/build |
/build |
* update vertical xgb examples for gpu support * formatting * add comment * update guide, finished testing multi-gpus * update for single gpu case * update readme --------- Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
Updated for recently added vertical xgboost gpu support.
Types of changes
./runtest.sh
.