Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vertical xgb examples for gpu support #1977

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

SYangster
Copy link
Collaborator

Updated for recently added vertical xgboost gpu support.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen previously approved these changes Sep 7, 2023
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Make sure you tested this in Multi-GPU

@SYangster
Copy link
Collaborator Author

Make sure you tested this in Multi-GPU

My machine only has 1 gpu, and I'm having issues building xgboost with nccl from source on our shared multi-gpu DGX due to outdated software, cuda etc. For this pr I was referencing the changes Rong made but I can mark as draft for now until we get the multi-gpu testing working.

@SYangster SYangster marked this pull request as draft September 7, 2023 21:42
@SYangster SYangster marked this pull request as ready for review September 12, 2023 23:31
YuanTingHsieh
YuanTingHsieh previously approved these changes Sep 13, 2023
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Changes LGTM.

We need to rebase on main and make sure these examples work.

Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chesterxgchen
Copy link
Collaborator

/build

@SYangster
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh
Copy link
Collaborator

/build

@SYangster SYangster merged commit 08b8f53 into NVIDIA:main Sep 19, 2023
15 checks passed
holgerroth pushed a commit to holgerroth/NVFlare that referenced this pull request Dec 4, 2023
* update vertical xgb examples for gpu support

* formatting

* add comment

* update guide, finished testing multi-gpus

* update for single gpu case

* update readme

---------

Co-authored-by: Yuan-Ting Hsieh (謝沅廷) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants