Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications for using Flask >=0.11 if available #1550

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

samikama
Copy link

Hello,
Two tiny modifications to be able to use more recent versions Flask, if user updated local installation for other purposes.

Cheers,
Sami

@samikama
Copy link
Author

Local execution of digits-lint seems to behave differently than in travis tests.. Curious

@lukeyeager
Copy link
Member

Local execution of digits-lint seems to behave differently than in travis tests.. Curious

It'll depend on which version of flake8 you have.

digits/views.py Outdated
# in werkzeug default_exceptions are valid
# [400, 401, 403, 404, 405, 406, 408, 409, 410,
# 411, 412, 413, 414, 415, 416, 417, 418, 422,
# 423, 428, 429, 431, 451, 500, 501, 502, 503, 504, 505]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any value in enumerating all these status codes.

@lukeyeager
Copy link
Member

Thanks for the PR @samikama! Can you send us a CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants