Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply rename to initialize_from_schema to ContrastiveOutput #1196

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Apply rename to initialize_from_schema to ContrastiveOutput #1196

merged 1 commit into from
Jul 11, 2023

Conversation

marcromeyn
Copy link
Contributor

@marcromeyn marcromeyn commented Jul 11, 2023 •
edited
Loading

Goals ⚽

#1186 renamed setup_schema to initialize_from_schema, this PR applies that rename to ContrastiveOutput which still used the old name.

@marcromeyn marcromeyn added bug Something isn't working area/pytorch labels Jul 11, 2023
@marcromeyn marcromeyn self-assigned this Jul 11, 2023
@marcromeyn marcromeyn marked this pull request as ready for review July 11, 2023 14:40
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1196

@edknv edknv merged commit 36d582a into main Jul 11, 2023
42 of 43 checks passed
@edknv edknv deleted the torch/contrastive-rename branch July 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverholworthy oliverholworthy oliverholworthy approved these changes

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch bug Something isn't working status/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcromeyn @oliverholworthy @edknv