-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing BatchBlock #1192
Merged
Merged
Introducing BatchBlock #1192
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
305dbd1
Introducing BatchBlock
marcromeyn 8b044f6
Introducing BatchBlock
marcromeyn 8be29d6
Adding type-hint to model.pre
marcromeyn 838265c
Adding doc-strings to BatchBlock
marcromeyn d34c081
Adding match= to pytest.raises
marcromeyn bedb91b
Adding EncoderBlock, this should be returned when you do model.select
marcromeyn 6a897d2
Running linting
marcromeyn 69d17df
Fixing merge-conflicts
marcromeyn 0a936a4
Running linting
marcromeyn 9383c27
Fix according to PR-comments
marcromeyn 33fc02f
Fix according to PR-comments
marcromeyn 34e893f
Merge branch 'main' into torch/batch-block
marcromeyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we need the
dummy_tensor
variable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never use it, but we need to have it in order to keep the type of the
Dict[str, torch.Tensor]
. We could store the original value but that might take more memory, so that's why I added the dummy. We only care about the keys of the original inputs.