Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CrossBlock (used in DCN-v2) #1172

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Adding CrossBlock (used in DCN-v2) #1172

merged 4 commits into from
Jul 3, 2023

Conversation

marcromeyn
Copy link
Contributor

@marcromeyn marcromeyn commented Jul 3, 2023 •
edited
Loading

Goals ⚽

This PR introduces the CrossBlock, this is the fundamental building block of the DCN-V2 model.

Implementation Details 🚧

This class uses an extra hook the first time it gets called to make sure LazyMirrorLinear is being initialized with the right parameters.

@marcromeyn marcromeyn self-assigned this Jul 3, 2023
@marcromeyn marcromeyn added enhancement New feature or request area/pytorch labels Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1172

@marcromeyn marcromeyn marked this pull request as ready for review July 3, 2023 10:46
@marcromeyn marcromeyn merged commit 593d78d into main Jul 3, 2023
35 checks passed
@marcromeyn marcromeyn deleted the torch/dcn branch July 3, 2023 12:04
@marcromeyn marcromeyn mentioned this pull request Jul 3, 2023
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

Assignees

@marcromeyn marcromeyn

Labels
area/pytorch enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcromeyn @edknv