Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and update tox environments #1168

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Rename and update tox environments #1168

merged 4 commits into from
Jul 1, 2023

Conversation

oliverholworthy
Copy link
Member

  • Remove python prefix from tox enivronment names, so that they can run in any Python version depending on the container they're being run inside.
  • Use posargs in places where tests folder is specified so that this can be specified on the command line (useful for local development/debugging)
  • Moves dependencies into deps section of tox environments where possible

@oliverholworthy oliverholworthy added this to the Merlin 23.07 milestone Jun 30, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 30, 2023
@oliverholworthy oliverholworthy changed the title Tox env rename py Rename and update tox environments Jun 30, 2023
@github-actions
Copy link

Documentation preview

https://nvidia-merlin.github.io/models/review/pr-1168

@edknv edknv merged commit 1783951 into NVIDIA-Merlin:main Jul 1, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edknv edknv edknv approved these changes

Assignees

@oliverholworthy oliverholworthy

Labels
ci
Projects
None yet
Milestone
Merlin 23.07
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverholworthy @edknv