Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to timeline.js to fix YouTube embeds #695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to timeline.js to fix YouTube embeds #695

wants to merge 1 commit into from

Conversation

flynnmartin
Copy link

When I tried a YouTube embed using the stock code, I couldn't get it to go by following the documentation for it. Changing the API calls to https and one URL seemed to fix the issue.

When I tried a YouTube embed using the stock code, I couldn't get it to go by following the documentation for it. Changing the API calls to https and one URL seemed to fix the issue.
@JoeGermuska
Copy link
Member

There don't seem to be any problems embedding YouTube URLs in any of our test cases. Can you provide the value you entered for the media URL?

for instance, I just used this YouTube URL on timeline.knightlab.com and got the expected behavior without your patch.

@flynnmartin
Copy link
Author

Unfortunately I used the "fixed" code on an internal-facing project at my last job, so I no longer have access to my original example. I'll see if I can come up with another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants