This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

Engineering Task Workflow

Jump to bottom

Jason Ji edited this page Jan 30, 2019 · 1 revision

Why

虽然task有时候很简单以至于感觉PR多此一举，但是PR有助于让大家了解互相的代码，互相学习以及及时发现问题提出整改意见。

Our GitHub repo enforces PR with at least 2 approvals to merge to master.

Workflow

Create a new branch and work on it.
I usually name the branch with username-issue#, but it's just personal preference for easy management.
Create a PR
At least 2 approvals is required to merge to master branch
Deploy to GitHub Pages:
```
npm run deploy
```