Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bridging functionallity to PHP. #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kalaspuffar
Copy link

This PR will add a couple of functions to the code so you can add this library as a PHP module and run it directly from the PHP code. I've seen that other glue codes have separate repositories, so this might not be how to implement this. I am still very early in my Rust journey, so I've not looked into multi-repository solutions.

I also did a small bug fix so the library doesn't have the name liblibmathcat.so

Best regards
Daniel

@NSoiffer
Copy link
Owner

Apologies for not seeing this earlier.

The way I have been dealing with language bindings is to have a separate repo (e.g, MathCATForC, MathCATForPython) that has wrappers for that language. The idea was not to "burden" the main library with these bindings. I don't think the current setup of using separate repos is a good idea and welcome suggestions for how to manage this better.

Two ideas that have come up:

If you have any thoughts on either approach or another approach, I'd appreciate your feedback. I have heard from some people that I should avoid github submodules.

Also see #193 for another approach to language bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants