Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename gamma r #1231

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Rename gamma r #1231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
471ecf0
renamed gamma_r to gamma_pmp where applicable
janinefreeman Oct 12, 2024
24b1f6c
Merge branch 'develop' into renameGammaR
janinefreeman Oct 28, 2024
04c7af5
remove gamma_pmp from pv6parmod and pvsamv1 since it is not used
janinefreeman Oct 28, 2024
4ebe777
Merge branch 'develop' into renameGammaR
janinefreeman Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ssc/cmod_pv6parmod.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ static var_info _cm_vtab_pv6parmod[] = {
{ SSC_INPUT, SSC_NUMBER, "Isc", "Short circuit current", "A", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "alpha_isc", "Temp coeff of current at SC", "A/'C", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "beta_voc", "Temp coeff of voltage at OC", "V/'C", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "gamma_pmp", "Temp coeff of power at MP", "%/'C", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "tnoct", "NOCT cell temperature", "'C", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "a", "Modified nonideality factor", "1/V", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
{ SSC_INPUT, SSC_NUMBER, "Il", "Light current", "A", "", "CEC 6 Parameter PV Module Model", "*", "", "" },
Expand Down
1 change: 0 additions & 1 deletion ssc/cmod_pvsamv1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,6 @@ static var_info _cm_vtab_pvsamv1[] = {
{ SSC_INPUT, SSC_NUMBER, "cec_adjust", "Temperature coefficient adjustment", "%", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
{ SSC_INPUT, SSC_NUMBER, "cec_alpha_sc", "Short circuit current temperature coefficient", "A/C", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
{ SSC_INPUT, SSC_NUMBER, "cec_beta_oc", "Open circuit voltage temperature coefficient", "V/C", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
{ SSC_INPUT, SSC_NUMBER, "cec_gamma_r", "Maximum power point temperature coefficient", "%/C", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
{ SSC_INPUT, SSC_NUMBER, "cec_i_l_ref", "Light current", "A", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
{ SSC_INPUT, SSC_NUMBER, "cec_i_mp_ref", "Maximum power point current", "A", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
{ SSC_INPUT, SSC_NUMBER, "cec_i_o_ref", "Saturation current", "A", "", "CEC Performance Model with Module Database", "module_model=1", "", "" },
Expand Down
2 changes: 0 additions & 2 deletions test/input_cases/pvsamv1_battery_common_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ void pvsamv1_pv_defaults(ssc_data_t& data) {
ssc_data_set_number(data, "cec_adjust", 22.909179999999999);
ssc_data_set_number(data, "cec_alpha_sc", 0.003735);
ssc_data_set_number(data, "cec_beta_oc", -0.175619);
ssc_data_set_number(data, "cec_gamma_r", -0.38600000000000001);
ssc_data_set_number(data, "cec_i_l_ref", 6.0537280000000004);
ssc_data_set_number(data, "cec_i_mp_ref", 5.6699999999999999);
ssc_data_set_number(data, "cec_i_o_ref", 8.3604350000000005e-11);
Expand Down Expand Up @@ -994,7 +993,6 @@ void commercial_multiarray_default(ssc_data_t& data) {
ssc_data_set_number(data, "cec_adjust", 22.909179999999999);
ssc_data_set_number(data, "cec_alpha_sc", 0.003735);
ssc_data_set_number(data, "cec_beta_oc", -0.175619);
ssc_data_set_number(data, "cec_gamma_r", -0.38600000000000001);
ssc_data_set_number(data, "cec_i_l_ref", 6.0537280000000004);
ssc_data_set_number(data, "cec_i_mp_ref", 5.6699999999999999);
ssc_data_set_number(data, "cec_i_o_ref", 8.3604350000000005e-11);
Expand Down
2 changes: 0 additions & 2 deletions test/input_cases/pvsamv1_common_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,6 @@ void pvsamv_nofinancial_default(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down Expand Up @@ -719,7 +718,6 @@ void pvsamv1_with_residential_default(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down
5 changes: 0 additions & 5 deletions test/input_cases/pvyield_common_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ void pvyield_no_financial_meteo(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down Expand Up @@ -658,7 +657,6 @@ void pvyield_bifacial_case(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down Expand Up @@ -1095,7 +1093,6 @@ void pvyield_user_support_80603_meteo(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down Expand Up @@ -1534,7 +1531,6 @@ void pvyield_user_support_80603_AZ(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down Expand Up @@ -1974,7 +1970,6 @@ void pvsamMPPT_nofinancial_default(ssc_data_t& data)
ssc_data_set_number(data, "cec_adjust", 5.0100002288818359);
ssc_data_set_number(data, "cec_alpha_sc", 0.0024920001160353422);
ssc_data_set_number(data, "cec_beta_oc", -0.16975000500679016);
ssc_data_set_number(data, "cec_gamma_r", -0.31000000238418579);
ssc_data_set_number(data, "cec_i_l_ref", 6.2369999885559082);
ssc_data_set_number(data, "cec_i_mp_ref", 5.8499999046325684);
ssc_data_set_number(data, "cec_i_o_ref", 3.9799999233813832e-12);
Expand Down