Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heating and Cooling Unavailable Days, follow-up #1315

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Oct 24, 2024

Pull Request Description

Need to fix a couple items:

  • we forgot to revert the temporary lines used for testing in ResStockArguments
  • Heating Unavailable Days = 1 day was setting 0 instead of 1 in the lookup

Related Pull Requests

[related PRs from different repositories]

Related Issues

[What issue(s) is the PR addressing]

Checklist

Required:

Optional (not all items may apply):

@joseph-robertson joseph-robertson added this to the ResStock v3.4.0 milestone Oct 24, 2024
@joseph-robertson joseph-robertson self-assigned this Oct 24, 2024
Copy link
Contributor

@afontani afontani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@joseph-robertson joseph-robertson marked this pull request as ready for review October 24, 2024 18:15
@joseph-robertson joseph-robertson merged commit 280a58c into develop Oct 25, 2024
@joseph-robertson joseph-robertson deleted the hvac-seasons-fix branch October 25, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants