-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add water heater location #1125
Conversation
31830f9
to
ec16e93
Compare
c3fc95e
to
6a079d6
Compare
new tsvs add 2021 n_buildings_rep count without AK HI fix error in update_yml_precomputed_files update CI action config
6a079d6
to
954a370
Compare
revert back to openstudio revert back to using openstudio add sudo update config and script
57e7a52
to
3eb67a0
Compare
…sstock into ll/water_heater_location
e2a90ee
to
c92ca65
Compare
…sstock into ll/water_heater_location
80e8ac7
to
5ac7506
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lixiliu This PR is looking good. Glad to see you were able to get the non deterministic E+ errors (?) sorted out. I have some general questions mainly around the config updates/changes, the recs2009 -> recs2020 changes, and changelog.
Make analysis-tests and integration-tests depend on unit-tests, which help to ensure options_lookup and housing characteristics are structurally consistent o run sampling
022707f
to
706aeef
Compare
So |
@joseph-robertson It's not a hard requirement for pre-computed test file update. It's just that the unit tests would be able to check for structural errors that would cause sampling to hang, so it would be nice to run that before both analysis and integration tests which involve running yamls. It's fine to roll back if that's preferred. |
|
||
- name: Download formatted options_lookup | ||
uses: actions/download-artifact@v3 | ||
with: | ||
path: resources | ||
name: options_lookup | ||
|
||
- name: Generate precomputed buildstocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Thank you!
Pull Request Description
Addresses Issue: #1094
ResStock-estimation companion PR: https://github.com/NREL/resstock-estimation/pull/385
Water Heater Location
(include fixing other tsvs to remove non-zero Void options)Geometry Space Combination
, a tsv that combines Geometry Building Type RECS, Geometry Building Level MF, Geometry Foundation Type, Geometry Attic Type, and Geometry Garage. It's used to define which combinations are valid and which are not (~80%) so that downstream tsvs (e.g., Water Heater Location and Duct Location) only use the valid options as a dependency and have smaller file size as a result.Geometry Garage
andGeometry Floor Area Bin
(no change as it is a lookup map) to RECS2020Comparison of CI artifact project_national results to Develop (i.e.,
./test/base_results/baseline/annual/results* - project_national rows
):water_heater_location_artifact_compare.xlsx
Checklist
Not all may apply:
If changes to project_testing tsvs, checklist includes yml_precomputed, yml_precomputed_outdated, yml_precomputed_weightopenstudio tasks.rb update_measures
has been run