Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CI tests for catching warnings thrown by run_analysis.rb #1102

Merged
merged 30 commits into from
Jul 25, 2023
Merged

Create CI tests for catching warnings thrown by run_analysis.rb #1102

merged 30 commits into from
Jul 25, 2023

Conversation

joseph-robertson
Copy link
Contributor

@joseph-robertson joseph-robertson commented Jul 14, 2023 •
edited
Loading

Pull Request Description

Addresses #1100.

Checklist

Not all may apply:

  • Tests (and test files) have been updated
  • Documentation has been updated
    • If related to resstock-estimation, checklist includes data dictionary, source report, options_lookup
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

@joseph-robertson joseph-robertson added this to the ResStock v3.2.0 milestone Jul 14, 2023
@joseph-robertson joseph-robertson self-assigned this Jul 14, 2023
@joseph-robertson joseph-robertson marked this pull request as ready for review July 17, 2023 18:23
@joseph-robertson joseph-robertson mentioned this pull request Jul 25, 2023
Open
@joseph-robertson joseph-robertson changed the title Create CI tests for catching warnings Create CI tests for catching warnings thrown by run_analysis.rb Jul 25, 2023
@joseph-robertson joseph-robertson merged commit 447a86f into develop Jul 25, 2023
7 checks passed
@joseph-robertson joseph-robertson deleted the catch-warnings branch July 25, 2023 13:56
shorowit
shorowit reviewed Jul 25, 2023
View reviewed changes
test/test_run_analysis.rb Show resolved Hide resolved
test/test_run_analysis.rb Show resolved Hide resolved
test/test_run_analysis.rb Show resolved Hide resolved
test/test_run_analysis.rb Show resolved Hide resolved
test/test_run_analysis.rb Show resolved Hide resolved
test/test_run_analysis.rb Show resolved Hide resolved
This was referenced Jul 25, 2023
Merged
Closed
@afontani afontani mentioned this pull request Aug 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

@aspeake aspeake aspeake left review comments

Assignees

@joseph-robertson joseph-robertson

Labels
None yet
Projects
None yet
Milestone
ResStock v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@joseph-robertson @shorowit @aspeake