HVAC Secondary Heating, try 2 #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…11036 12333b11036 Merge pull request #1414 from NREL/heating_system_2 0ac7de4c9fc Re-enable warning. [ci skip] 59035cc3392 Merge pull request #1415 from NREL/v170 e6eab0a1c1a Prep for v1.7.0 f798647d40f Latest results. fb2fd345e3d Fix bugs related to hvac distribution assignment. 69937ba9750 Add sample file for shared boiler with secondary fireplace. 2cff2ae3ee6 Merge pull request #1405 from NREL/foundation_hpxmls a2d07f76b2d Latest results. 6c6279b2450 Cleanup some HPXML files with respect to foundation inputs. git-subtree-dir: resources/hpxml-measures git-subtree-split: 12333b1103684714d91915631112633abf2f2f32
rajeee
reviewed
Jul 14, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Companion PR: https://github.com/NREL/resstock-estimation/pull/375
Support options sampled from
HVAC Secondary Heating xxx. Update the ResStockArguments measure to adjust the primary system's fraction of heat load served such that the sum of fractions does not exceed 1.0, for the following:heating_system_type!=noneheat_pump_type!=noneThis PR also pulls in the develop branch of OS-HPXML containing related fixes in NREL/OpenStudio-HPXML#1414.
Checklist
Not all may apply:
openstudio tasks.rb update_measureshas been run