Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matt updats to SRR and CODS #417

Merged
merged 46 commits into from
Aug 2, 2024
Merged

Conversation

noromo01
Copy link
Collaborator

Matt’s updates to SRR algorithm (detect negative shifts in soiling ratio and fit multiple soiling rates per soiling interval (piecewise)) as well as CODS algorithm being added

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

cdeline and others added 16 commits May 25, 2023 14:24
* add wrapper clearsky_filter

* rename filter to model

* update analysis_chains with  clearsky filter wrapper

* update clearsky tests

* update default filter params

* add pending changelog

* update init.py

* update api.rst

* add test for clearsky_filter function

* remove experimental warning for logic_clip_filter test

* re-run notebook

* update configparser deprecated arguments python 3.12

* Use csi clearsky filter in a number of tests

* Adjust how attributes are removed for error testing

* fix linting in analysis_chains_test

* update numexpr to 2.10

* update h5py requirements to 3.11

* Revert "re-run notebook"

This reverts commit 751cfaa.

* update notebook requirements

* save degradation notebook without logic filter warning

* availability notebook avoid double plotting figures

* re-run TrendAnalysis notebook

* Revert "re-run TrendAnalysis notebook"

This reverts commit 3e91ada.

* restart kernel and re-run TrendAnalysis notebook

* update change log

* add line to change log

* further changelog fixes

---------

Co-authored-by: Michael Deceglie <[email protected]>
…tio and fit multiple soiling rates per soiling interval (piecewise)) as well as CODS algorithm being added
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.68421% with 90 lines in your changes missing coverage. Please review.

Project coverage is 72.80%. Comparing base (bb24f06) to head (9e3a411).

Files Patch % Lines
rdtools/filtering.py 65.74% 62 Missing ⚠️
rdtools/analysis_chains.py 83.22% 26 Missing ⚠️
versioneer.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #417      +/-   ##
===============================================
- Coverage        73.88%   72.80%   -1.09%     
===============================================
  Files               13       13              
  Lines             2711     2982     +271     
===============================================
+ Hits              2003     2171     +168     
- Misses             708      811     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-springer martin-springer changed the base branch from development to dev_SRR_CODS August 2, 2024 18:14
@martin-springer martin-springer merged commit 9e3d89d into NREL:dev_SRR_CODS Aug 2, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants