-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return results instead of none when CODS soiling signal is small #400
Conversation
I re-ran the offending notebook and scrutinized the output to be sure no substantial changes occurred in the outputs. That plot does appear to change size, but I don't think it is a concern. |
"'{}' was expected as a column, but not in result_df".format(x) | ||
|
||
|
||
def test_soiling_cods_small_signal(cods_normalized_daily_small_soiling): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the CODS small signal test
I did update all packages in my conda environment and saved the notebook. Somehow, there's still a discrepancy in one cell. I could try re-creating a new environment the exact way nbval does here. On the other hand, we get quite a lot of warning and deprecation messages. Might be time to start resolving them. |
I think we can look past the notebook failure this time. I opened #401 today because of the message we're seeing in the notebook. |
Let's get the change log updated, then I think we can move forward with this. The version will be |
Sounds good, I updated the changelog. Could you merge these changes into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks @martin-springer!
[ ] New functions added to__init__.py
[ ] API.rst is up to date, along with other sphinx docs pages