Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change filt variable from global to local #389

Closed
wants to merge 2 commits into from
Closed

change filt variable from global to local #389

wants to merge 2 commits into from

Conversation

martin-springer
Copy link
Collaborator

  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

mdeceglie
mdeceglie reviewed Sep 12, 2023
View reviewed changes
rdtools/normalization.py
csi = irrad / (guess * irrad_sim) # clear sky index
filt = (csi >= 0.8) & (csi <= 1.2) & (irrad > 200)
min_result = minimize(_rmse, guess, method='Nelder-Mead')
min_result = minimize(_rmse, guess, (filt), method='Nelder-Mead')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need to use a lambda function like lambda x : _rmse(x, filt) here as the first argument to minimize

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdeceglie - I'm not seeing why we might need a lambda function. I created a jupyter notebook that re-creates the analysis and I obtain the same result between my suggested changes and the initial implementation. I opened a new PR #399 from the master branch to have running tests and to check whether my changes cause any troubles. So far, all pytests seem to be passing.

@mdeceglie
Copy link
Collaborator

Replaced with #399

@mdeceglie mdeceglie closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeceglie mdeceglie mdeceglie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-springer @mdeceglie