Dont replicate nans in time #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
approved these changes
Oct 21, 2024
flasc/utilities/tuner_utilities.py
Outdated
| @@ -49,6 +49,10 @@ def replicate_nan_values( | |||
| # Identify common columns between df_1 and df_2 | |||
| common_columns = df_1.columns.intersection(df_2.columns) | |||
|
|
|||
| # Remove the time column from the common columns if included | |||
| if "time" in common_columns: | |||
| common_columns = common_columns.drop("time") | |||
There was a problem hiding this comment.
Might be cleaner to use pandas' built-in check for whether the column exists to avoid the if statement?
# Remove the time columns from the common_columns if included
common_columns.drop("time", errors="ignore")Either way is fine though.
There was a problem hiding this comment.
Good suggestion, using that syntax, thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very small fix to the function
replicate_nan_valueswhich replicates NaN values in columns that are common between two dataframes from one to another. For some reason this does not work for the time column when it is of typeDateTime64DType. However, I can't think of a good reason we need to expect to replicate nans in the time column (this functionality is for marking missing turbine data). So simply omitting this column avoids the issue.