[BUGFIX] Inverse channel_name_map
fix for FlascDataFrame
#222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulf81 pointed out a bug on
FlascDataFrame
that arose when thechannel_name_map
property is set after instantiation. In this case, the hidden property_channel_name_map_inverse
was not generated correctly to follow. In principle, this could have been fixed by using a setter method forchannel_name_map
(that also sets_channel_name_map_inverse
); however, I was having issues with recursion when using getters/setters forchannel_name_map
.As the inverse map is only used within the one method of
FlascDataFrame
,convert_to_user_format()
, the approach taken here is to simply remove the_channel_name_map_inverse
attribute entirely and instead create the inverse map fromchannel_name_map
on the fly whenconvert_to_user_format()
is called.